runtime: temporarily skip gdb python-related tests on solaris

binarycrusader · bradfitz · commit e7823d656e81 · 2017-06-28T05:01:20.000Z
Updates #20821 Change-Id: I77a5b9a3bbb931845ef52a479549d71069af9540 Reviewed-on: https://go-review.googlesource.com/46913 Run-TryBot: Shawn Walker-Salas <shawn.walker@oracle.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org> Reviewed-by: Ian Lance Taylor <iant@golang.org>
diff --git a/src/runtime/runtime-gdb_test.go b/src/runtime/runtime-gdb_test.go
@@ -56,6 +56,10 @@ func checkGdbVersion(t *testing.T) {
 }
 
 func checkGdbPython(t *testing.T) {
+	if runtime.GOOS == "solaris" && testenv.Builder() != "solaris-amd64-smartosbuildlet" {
+		t.Skip("skipping gdb python tests on solaris; see golang.org/issue/20821")
+	}
+
 	cmd := exec.Command("gdb", "-nx", "-q", "--batch", "-iex", "python import sys; print('go gdb python support')")
 	out, err := cmd.CombinedOutput()
 

Original file line number	Diff line number	Diff line change
`@@ -56,6 +56,10 @@ func checkGdbVersion(t *testing.T) {`
`56`	`56`	`}`
`57`	`57`
`58`	`58`	`func checkGdbPython(t *testing.T) {`
	`59`	`+ if runtime.GOOS == "solaris" && testenv.Builder() != "solaris-amd64-smartosbuildlet" {`
	`60`	`+ t.Skip("skipping gdb python tests on solaris; see golang.org/issue/20821")`
	`61`	`+ }`
	`62`	`+`
`59`	`63`	`cmd := exec.Command("gdb", "-nx", "-q", "--batch", "-iex", "python import sys; print('go gdb python support')")`
`60`	`64`	`out, err := cmd.CombinedOutput()`
`61`	`65`