cmd/go: convert even more module tests to scripts

Change-Id: Iba185e00e9df2462e9089566053f6c64e24a6a92
Reviewed-on: https://go-review.googlesource.com/124698
Reviewed-by: Bryan C. Mills <[email protected]>

Author: rsc

src/cmd/go/mod_test.go

@@ -9,7 +9,6 @@ import (
 	"internal/testenv"
 	"io/ioutil"
 	"os"
-	"os/exec"
 	"path/filepath"
 	"regexp"
 	"sort"
@@ -635,62 +634,6 @@ func TestModGetUpgrade(t *testing.T) {
 	tg.grepStderr(`go get: disabled by -getmode=vendor`, "expected disabled")
 }
 
-func TestModPathCase(t *testing.T) {
-	tg := testGoModules(t)
-	defer tg.cleanup()
-
-	tg.run("get", "rsc.io/QUOTE")
-
-	tg.run("list", "-m", "all")
-	tg.grepStdout(`^rsc.io/quote v1.5.2`, "want lower-case quote v1.5.2")
-	tg.grepStdout(`^rsc.io/QUOTE v1.5.2`, "want upper-case quote v1.5.2")
-
-	// Note: the package is rsc.io/QUOTE/QUOTE to avoid
-	// a case-sensitive import collision error in load/pkg.go.
-	tg.run("list", "-f=DEPS {{.Deps}}\nDIR {{.Dir}}", "rsc.io/QUOTE/QUOTE")
-	tg.grepStdout(`DEPS.*rsc.io/quote`, "want quote as dep")
-	tg.grepStdout(`DIR.*!q!u!o!t!e`, "want !q!u!o!t!e in directory name")
-}
-
-func TestModFileNames(t *testing.T) {
-	tg := testGoModules(t)
-	defer tg.cleanup()
-
-	tg.runFail("get",
-		"rsc.io/badfile1",
-		"rsc.io/badfile2",
-		"rsc.io/badfile3",
-		"rsc.io/badfile4",
-		"rsc.io/badfile5",
-	)
-	tg.grepStderrNot(`unzip .*badfile1.*:`, "badfile1 should be OK")
-	tg.grepStderr(`rsc.io/badfile2.*malformed file path "☺.go": invalid char '☺'`, "want diagnosed invalid character")
-	tg.grepStderr(`rsc.io/badfile3.*malformed file path "x\?y.go": invalid char '\?'`, "want diagnosed invalid character")
-	tg.grepStderr(`rsc.io/badfile4.*case-insensitive file name collision: "x/Y.go" and "x/y.go"`, "want case collision")
-	tg.grepStderr(`rsc.io/badfile5.*case-insensitive file name collision: "x/y" and "x/Y"`, "want case collision")
-}
-
-func TestModBadDomain(t *testing.T) {
-	tg := testGoModules(t)
-	defer tg.cleanup()
-
-	tg.tempFile("work/x.go", `
-		package x
-
-		import _ "appengine"
-		import _ "nonexistent.rsc.io" // domain does not exist
-	`)
-
-	tg.runFail("get", "appengine")
-	tg.grepStderr(`cannot find module providing package appengine`, "expected module error ")
-	tg.runFail("get", "x/y.z")
-	tg.grepStderr(`cannot find module providing package x/y.z`, "expected module error")
-
-	tg.runFail("build")
-	tg.grepStderrNot("unknown module appengine: not a domain name", "expected nothing about appengine")
-	tg.grepStderr("cannot find module providing package nonexistent.rsc.io", "expected error for nonexistent.rsc.io")
-}
-
 func TestModSync(t *testing.T) {
 	tg := testGoModules(t)
 	defer tg.cleanup()
@@ -851,306 +794,6 @@ func TestModVendor(t *testing.T) {
 	}
 }
 
-func TestModList(t *testing.T) {
-	tg := testGoModules(t)
-	defer tg.cleanup()
-
-	tg.setenv(homeEnvName(), tg.path("."))
-	tg.must(os.MkdirAll(tg.path("x"), 0777))
-	tg.must(ioutil.WriteFile(tg.path("x/x.go"), []byte(`
-		package x
-		import _ "rsc.io/quote"
-	`), 0666))
-	tg.must(ioutil.WriteFile(tg.path("x/go.mod"), []byte(`
-		module x
-		require rsc.io/quote v1.5.2
-	`), 0666))
-	tg.cd(tg.path("x"))
-
-	tg.run("list", "-m", "-f={{.Main}}: {{.Dir}}")
-	tg.grepStdout(`^true: `, "expected main module to have Main=true")
-	tg.grepStdout(regexp.QuoteMeta(tg.path("x")), "expected Dir of main module to be present")
-
-	tg.run("list", "-m", "-f={{.Main}}: {{.Dir}}", "rsc.io/quote")
-	tg.grepStdout(`^false: `, "expected non-main module to have Main=false")
-	tg.grepStdoutNot(`quote@`, "should not have local copy of code")
-
-	tg.run("list", "-f={{.Dir}}", "rsc.io/quote") // downloads code to load package
-	tg.grepStdout(`mod[\\/]rsc.io[\\/][email protected]`, "expected cached copy of code")
-	dir := strings.TrimSpace(tg.getStdout())
-	info, err := os.Stat(dir)
-	if err != nil {
-		t.Fatal(err)
-	}
-	if info.Mode()&0222 != 0 {
-		t.Fatalf("%s should be unwritable", dir)
-	}
-	info, err = os.Stat(filepath.Join(dir, "buggy"))
-	if err != nil {
-		t.Fatal(err)
-	}
-	if info.Mode()&0222 != 0 {
-		t.Fatalf("%s should be unwritable", filepath.Join(dir, "buggy"))
-	}
-
-	tg.run("clean", "-modcache")
-	if _, err = os.Stat(dir); err == nil {
-		t.Fatal("clean -modcache did not remove download dir")
-	}
-
-	tg.must(ioutil.WriteFile(tg.path("x/go.mod"), []byte(`
-		module x
-		require rsc.io/quote v1.5.1
-		replace rsc.io/sampler v1.3.0 => rsc.io/sampler v1.3.1
-	`), 0666))
-
-	tg.run("list", "-f={{.Dir}}", "rsc.io/quote") // downloads code to load package
-	tg.run("list", "-m", "-f={{.Path}} {{.Version}} {{.Dir}}{{with .Replace}} => {{.Version}} {{.Dir}}{{end}}", "all")
-	tg.grepStdout(`mod[\\/]rsc.io[\\/][email protected]`, "expected cached copy of code")
-	tg.grepStdout(`v1.3.0 .*mod[\\/]rsc.io[\\/][email protected] => v1.3.1 .*@v1.3.1`, "expected v1.3.1 replacement")
-
-	// check that list std works; also check that rsc.io/quote/buggy is a listable package
-	tg.run("list", "std", "rsc.io/quote/buggy")
-	tg.grepStdout("^math/big", "expected standard library")
-
-	tg.run("list", "-m", "-e", "-f={{.Path}} {{.Error.Err}}", "nonexist", "rsc.io/quote/buggy")
-	tg.grepStdout(`^nonexist module "nonexist" is not a known dependency`, "expected error via template")
-	tg.grepStdout(`^rsc.io/quote/buggy module "rsc.io/quote/buggy" is not a known dependency`, "expected error via template")
-
-	tg.runFail("list", "-m", "nonexist", "rsc.io/quote/buggy")
-	tg.grepStderr(`go list -m nonexist: module "nonexist" is not a known dependency`, "expected error on stderr")
-	tg.grepStderr(`go list -m rsc.io/quote/buggy: module "rsc.io/quote/buggy" is not a known dependency`, "expected error on stderr")
-
-	// Check that module loader does not interfere with list -e (golang.org/issue/24149).
-	tg.run("list", "-e", "-f={{.ImportPath}} {{.Error.Err}}", "database")
-	tg.grepStdout(`^database no Go files in `, "expected error via template")
-	tg.runFail("list", "database")
-	tg.grepStderr(`package database: no Go files`, "expected error on stderr")
-
-}
-
-func TestModInitLegacy(t *testing.T) {
-	testenv.MustHaveExternalNetwork(t)
-	if _, err := exec.LookPath("git"); err != nil {
-		t.Skip("skipping because git binary not found")
-	}
-
-	tg := testGoModules(t)
-	defer tg.cleanup()
-
-	tg.setenv(homeEnvName(), tg.path("."))
-	tg.must(os.MkdirAll(tg.path("x"), 0777))
-	tg.must(ioutil.WriteFile(tg.path("x/x.go"), []byte(`
-		package x
-	`), 0666))
-
-	tg.must(ioutil.WriteFile(tg.path("x/go.mod"), []byte(`
-		module x
-	`), 0666))
-	tg.must(ioutil.WriteFile(tg.path("x/Gopkg.lock"), []byte(`
-[[projects]]
-  name = "rsc.io/sampler"
-  version = "v1.0.0"
-	`), 0666))
-
-	tg.cd(tg.path("x"))
-	tg.run("build", "-v")
-	tg.grepStderr("copying requirements from .*Gopkg.lock", "did not copy Gopkg.lock")
-	tg.run("list", "-m", "all")
-	tg.grepStderrNot("copying requirements from .*Gopkg.lock", "should not copy Gopkg.lock again")
-	tg.grepStdout("rsc.io/sampler.*v1.0.0", "did not copy Gopkg.lock")
-
-	tg.must(ioutil.WriteFile(tg.path("x/go.mod"), []byte(`
-		module x
-	`), 0666))
-	tg.must(ioutil.WriteFile(tg.path("x/Gopkg.lock"), []byte(`
-	`), 0666))
-
-	tg.run("list")
-	tg.grepStderr("copying requirements from .*Gopkg.lock", "did not copy Gopkg.lock")
-	tg.run("list")
-	tg.grepStderrNot("copying requirements from .*Gopkg.lock", "should not copy Gopkg.lock again")
-}
-
-func TestModInitLegacy2(t *testing.T) {
-	testenv.MustHaveExternalNetwork(t)
-	if _, err := exec.LookPath("git"); err != nil {
-		t.Skip("skipping because git binary not found")
-	}
-
-	tg := testGoModules(t)
-	defer tg.cleanup()
-
-	tg.setenv(homeEnvName(), tg.path("."))
-
-	// Testing that on Windows the path x/Gopkg.lock turning into x\Gopkg.lock does not confuse converter.
-	tg.must(os.MkdirAll(tg.path("x"), 0777))
-	tg.must(ioutil.WriteFile(tg.path("x/Gopkg.lock"), []byte(`
-	  [[projects]]
-		name = "rsc.io/quote"
-		packages = ["."]
-		revision = "645ef00459ed84a119197bfb8d8205042c6df63d"
-		version = "v1.4.0"`), 0666))
-	tg.must(ioutil.WriteFile(tg.path("x/main.go"), []byte("package x // import \"x\"\n import _ \"github.com/pkg/errors\""), 0666))
-	tg.cd(tg.path("x"))
-	tg.run("list", "-m", "all")
-
-	// If the conversion just ignored the Gopkg.lock entirely
-	// it would choose a newer version (like v1.5.2 or maybe
-	// something even newer). Check for the older version to
-	// make sure Gopkg.lock was properly used.
-	tg.grepStdout("v1.4.0", "expected rsc.io/quote at v1.4.0")
-}
-
-func TestModVerify(t *testing.T) {
-	tg := testGoModules(t)
-	defer tg.cleanup()
-
-	gopath := tg.path("gp")
-	tg.setenv("GOPATH", gopath)
-	tg.must(os.MkdirAll(tg.path("x"), 0777))
-	tg.must(ioutil.WriteFile(tg.path("x/go.mod"), []byte(`
-		module x
-		require rsc.io/quote v1.1.0
-	`), 0666))
-	tg.must(ioutil.WriteFile(tg.path("x/x.go"), []byte(`package x; import _ "rsc.io/quote"`), 0666))
-
-	// With correct go.sum,verify succeeds but avoids download.
-	tg.must(ioutil.WriteFile(tg.path("x/go.sum"), []byte(`rsc.io/quote v1.1.0 h1:WdK/asTD0HN+q6hsWO3/vpuAkAr+tw6aNJNDFFf0+qw=
-`), 0666))
-	tg.cd(tg.path("x"))
-	tg.run("mod", "-verify")
-	tg.mustNotExist(filepath.Join(gopath, "src/mod/cache/download/rsc.io/quote/@v/v1.1.0.zip"))
-	tg.mustNotExist(filepath.Join(gopath, "src/mod/github.com/pkg"))
-
-	// With incorrect sum, sync (which must download) fails.
-	// Even if the incorrect sum is in the old legacy go.modverify file.
-	tg.must(ioutil.WriteFile(tg.path("x/go.sum"), []byte(`
-`), 0666))
-	tg.must(ioutil.WriteFile(tg.path("x/go.modverify"), []byte(`rsc.io/quote v1.1.0 h1:a3YaZoizPtXyv6ZsJ74oo2L4/bwOSTKMY7MAyo4O/1c=
-`), 0666))
-	tg.runFail("mod", "-sync") // downloads pkg/errors
-	tg.grepStderr("checksum mismatch", "must detect mismatch")
-	tg.mustNotExist(filepath.Join(gopath, "src/mod/cache/download/rsc.io/quote/@v/v1.1.0.zip"))
-	tg.mustNotExist(filepath.Join(gopath, "src/mod/github.com/pkg"))
-
-	// With corrected sum, sync works.
-	tg.must(ioutil.WriteFile(tg.path("x/go.modverify"), []byte(`rsc.io/quote v1.1.0 h1:a3YaZoizPtXyv6ZsJ74oo2L4/bwOSTKMY7MAyo4O/0c=
-`), 0666))
-	tg.run("mod", "-sync")
-	tg.mustExist(filepath.Join(gopath, "src/mod/cache/download/rsc.io/quote/@v/v1.1.0.zip"))
-	tg.mustExist(filepath.Join(gopath, "src/mod/rsc.io"))
-	tg.mustNotExist(tg.path("x/go.modverify")) // moved into go.sum
-
-	// Sync should have added sum for go.mod.
-	data, err := ioutil.ReadFile(tg.path("x/go.sum"))
-	if !strings.Contains(string(data), "\nrsc.io/quote v1.1.0/go.mod ") {
-		t.Fatalf("cannot find go.mod hash in go.sum: %v\n%s", err, data)
-	}
-
-	// Verify should work too.
-	tg.run("mod", "-verify")
-
-	// Even the most basic attempt to load the module graph should detect incorrect go.mod files.
-	tg.run("mod", "-graph") // loads module graph, is OK
-	tg.must(ioutil.WriteFile(tg.path("x/go.sum"), []byte(`rsc.io/quote v1.1.0 a3YaZoizPtXyv6ZsJ74oo2L4/bwOSTKMY7MAyo4O/1c=
-rsc.io/quote v1.1.0/go.mod h1:bwawxfHBFNV+L2hUp1rHADufV3IMtnDRdf1r5NINEl1=
-`), 0666))
-	tg.runFail("mod", "-graph") // loads module graph, fails (even though sum is in old go.modverify file)
-	tg.grepStderr("go.mod: checksum mismatch", "must detect mismatch")
-
-	// go.sum should be created and updated automatically.
-	tg.must(os.Remove(tg.path("x/go.sum")))
-	tg.run("mod", "-graph")
-	tg.mustExist(tg.path("x/go.sum"))
-	data, err = ioutil.ReadFile(tg.path("x/go.sum"))
-	if !strings.Contains(string(data), " v1.1.0/go.mod ") {
-		t.Fatalf("cannot find go.mod hash in go.sum: %v\n%s", err, data)
-	}
-	if strings.Contains(string(data), " v1.1.0 ") {
-		t.Fatalf("unexpected module tree hash in go.sum: %v\n%s", err, data)
-	}
-	tg.run("mod", "-sync")
-	data, err = ioutil.ReadFile(tg.path("x/go.sum"))
-	if !strings.Contains(string(data), " v1.1.0/go.mod ") {
-		t.Fatalf("cannot find go.mod hash in go.sum: %v\n%s", err, data)
-	}
-	if !strings.Contains(string(data), " v1.1.0 ") {
-		t.Fatalf("cannot find module tree hash in go.sum: %v\n%s", err, data)
-	}
-
-	tg.must(os.Remove(filepath.Join(gopath, "src/mod/cache/download/rsc.io/quote/@v/v1.1.0.ziphash")))
-	tg.run("mod", "-sync") // ignores missing ziphash file for ordinary go.sum validation
-
-	tg.runFail("mod", "-verify") // explicit verify fails with missing ziphash
-
-	tg.run("mod", "-droprequire", "rsc.io/quote")
-	tg.run("list", "rsc.io/quote/buggy")
-	data, err = ioutil.ReadFile(tg.path("x/go.sum"))
-	if strings.Contains(string(data), "buggy") {
-		t.Fatalf("did not expect buggy in go.sum:\n%s", data)
-	}
-	if !strings.Contains(string(data), "rsc.io/quote v1.5.2/go.mod") {
-		t.Fatalf("did expect rsc.io/quote go.mod in go.sum:\n%s", data)
-	}
-
-	tg.run("mod", "-droprequire", "rsc.io/quote")
-	tg.runFail("list", "rsc.io/quote/buggy/foo")
-	data, err = ioutil.ReadFile(tg.path("x/go.sum"))
-	if strings.Contains(string(data), "buggy") {
-		t.Fatalf("did not expect buggy in go.sum:\n%s", data)
-	}
-	if !strings.Contains(string(data), "rsc.io/quote v1.5.2/go.mod") {
-		t.Fatalf("did expect rsc.io/quote go.mod in go.sum:\n%s", data)
-	}
-
-	tg.run("mod", "-droprequire", "rsc.io/quote")
-	tg.runFail("list", "rsc.io/quote/morebuggy")
-	if strings.Contains(string(data), "morebuggy") {
-		t.Fatalf("did not expect morebuggy in go.sum:\n%s", data)
-	}
-	if !strings.Contains(string(data), "rsc.io/quote v1.5.2/go.mod") {
-		t.Fatalf("did expect rsc.io/quote go.mod in go.sum:\n%s", data)
-	}
-}
-
-func TestModFileProxy(t *testing.T) {
-	tg := testGoModules(t)
-	defer tg.cleanup()
-
-	tg.setenv("GOPATH", tg.path("gp1"))
-
-	tg.must(os.MkdirAll(tg.path("x"), 0777))
-	tg.must(ioutil.WriteFile(tg.path("x/main.go"), []byte(`package x; import _ "rsc.io/quote"`), 0666))
-	tg.must(ioutil.WriteFile(tg.path("x/go.mod"), []byte(`module x
-		require rsc.io/quote v1.5.1`), 0666))
-	tg.cd(tg.path("x"))
-	tg.run("list", "all")
-	tg.run("list", "-getmode=local", "all")
-	tg.mustExist(tg.path("gp1/src/mod/cache/download/rsc.io/quote/@v/list"))
-
-	// @v/list should contain version list.
-	data, err := ioutil.ReadFile(tg.path("gp1/src/mod/cache/download/rsc.io/quote/@v/list"))
-	if err != nil {
-		t.Fatal(err)
-	}
-	if !strings.Contains(string(data), "v1.5.1\n") {
-		t.Fatalf("cannot find v1.5.1 in @v/list:\n%s", data)
-	}
-
-	tg.setenv("GOPROXY", "file:///nonexist")
-	tg.run("list", "-getmode=local", "all")
-
-	tg.setenv("GOPATH", tg.path("gp2"))
-	tg.runFail("list", "-getmode=local", "all")
-	tg.runFail("list", "all") // because GOPROXY is bogus
-
-	tg.setenv("GOPROXY", "file://"+filepath.ToSlash(tg.path("gp1/src/mod/cache/download")))
-	tg.runFail("list", "-getmode=local", "all")
-	tg.run("list", "all")
-	tg.mustExist(tg.path("gp2/src/mod/cache/download/rsc.io/quote/@v/list"))
-}
-
 func TestModMultiVersion(t *testing.T) {
 	tg := testGoModules(t)
 	defer tg.cleanup()

src/cmd/go/testdata/script/mod_bad_domain.txt

@@ -0,0 +1,21 @@
+env GO111MODULE=on
+
+# explicit get should report errors about bad names
+! go get appengine
+stderr 'cannot find module providing package appengine'
+! go get x/y.z
+stderr 'cannot find module providing package x/y.z'
+
+# build should skip over appengine imports
+! go build
+! stderr appengine
+stderr 'cannot find module providing package nonexistent.rsc.io'
+
+-- go.mod --
+module x
+
+-- x.go --
+package x
+
+import _ "appengine"
+import _ "nonexistent.rsc.io" // domain does not exist