Skip to content

Commit e308d41

Browse files
committed
unicode: update table using new generator in x/text
The changes in Unicode 11 exposes a bug in maketables.go. We update the Unicode 10 tables using a new generator to minimize the changes upgrading to Unicode 11. This change switches over the generation from core to that in x/text. To properly update the tables one needs to run the generate in x/text anyway, so this makes that official. The RangeTable generator in x/text also generates slightly compacter tables. Updates #27945 See CL 154443 Change-Id: I6c59e082d5b8cd9e9332a32d8971061228581d66 Reviewed-on: https://go-review.googlesource.com/c/go/+/169617 Run-TryBot: Marcel van Lohuizen <[email protected]> TryBot-Result: Gobot Gobot <[email protected]> Reviewed-by: Brad Fitzpatrick <[email protected]>
1 parent 80e7832 commit e308d41

File tree

3 files changed

+507
-2166
lines changed

3 files changed

+507
-2166
lines changed

src/unicode/letter.go

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,9 +6,6 @@
66
// Unicode code points.
77
package unicode
88

9-
// Tables are regenerated each time we update the Unicode version.
10-
//go:generate go run maketables.go -tables=all -output tables.go
11-
129
const (
1310
MaxRune = '\U0010FFFF' // Maximum valid Unicode code point.
1411
ReplacementChar = '\uFFFD' // Represents invalid code points.

0 commit comments

Comments
 (0)