Skip to content

Commit e1e10e6

Browse files
committed
go/types, types2: require CGO for TestIssue59944
This test is failing on the nocgo builder. Change-Id: I9426ce77907956e4654fd437ad20e3af664e83ab Reviewed-on: https://go-review.googlesource.com/c/go/+/497436 Run-TryBot: Robert Findley <[email protected]> Reviewed-by: Robert Griesemer <[email protected]> TryBot-Result: Gopher Robot <[email protected]>
1 parent 876eca7 commit e1e10e6

File tree

2 files changed

+4
-12
lines changed

2 files changed

+4
-12
lines changed

src/cmd/compile/internal/types2/issues_test.go

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,6 @@ import (
1111
"fmt"
1212
"internal/testenv"
1313
"regexp"
14-
"runtime"
1514
"sort"
1615
"strings"
1716
"testing"
@@ -807,11 +806,8 @@ func (S) M5(struct {S;t}) {}
807806
}
808807

809808
func TestIssue59944(t *testing.T) {
810-
if runtime.GOARCH == "wasm" {
811-
// While we don't use the cgo tool directly in this test, we must have the
812-
// syscall package.
813-
t.Skip("cgo generated code does not compile on wasm")
814-
}
809+
testenv.MustHaveCGO(t)
810+
815811
// The typechecker should resolve methods declared on aliases of cgo types.
816812
const src = `
817813
package p

src/go/types/issues_test.go

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,6 @@ import (
1313
"go/token"
1414
"internal/testenv"
1515
"regexp"
16-
"runtime"
1716
"sort"
1817
"strings"
1918
"testing"
@@ -846,11 +845,8 @@ func (S) M5(struct {S;t}) {}
846845
}
847846

848847
func TestIssue59944(t *testing.T) {
849-
if runtime.GOARCH == "wasm" {
850-
// While we don't use the cgo tool directly in this test, we must have the
851-
// syscall package.
852-
t.Skip("cgo generated code does not compile on wasm")
853-
}
848+
testenv.MustHaveCGO(t)
849+
854850
// The typechecker should resolve methods declared on aliases of cgo types.
855851
const src = `
856852
package p

0 commit comments

Comments
 (0)