Skip to content

Commit dd1e7b3

Browse files
committed
crypto/x509: update __MAC_OS_X_VERSION_MAX_ALLOWED on Mac
Reportedly, -mmacosx-version-min=10.6 -D__MAC_OS_X_VERSION_MAX_ALLOWED=1060 is problematic. It means min 10.6 and max 10.6, thus exactly 10.6. But we only support 10.8+. It never caused us problems, because we build on Macs, but apparently if you cross-compile from Linux with some Mac compiler SDK thing, then things break? This was added in https://golang.org/cl/5700083 for #3131, and the intent at the time was to pin to exactly 10.6. So it wasn't a mistake, but it is definitely outdated. Given that we now support 10.8 as the min, update it to 1080. Fixes #17732 Change-Id: I6cc8ab6ac62b8638a5025952b830f23e8822b2a6 Reviewed-on: https://go-review.googlesource.com/32580 Reviewed-by: Josh Bleecher Snyder <[email protected]> Reviewed-by: Russ Cox <[email protected]> Reviewed-by: Quentin Smith <[email protected]> Run-TryBot: Brad Fitzpatrick <[email protected]>
1 parent 039e60c commit dd1e7b3

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

src/crypto/x509/root_cgo_darwin.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
package x509
88

99
/*
10-
#cgo CFLAGS: -mmacosx-version-min=10.6 -D__MAC_OS_X_VERSION_MAX_ALLOWED=1060
10+
#cgo CFLAGS: -mmacosx-version-min=10.6 -D__MAC_OS_X_VERSION_MAX_ALLOWED=1080
1111
#cgo LDFLAGS: -framework CoreFoundation -framework Security
1212
1313
#include <errno.h>

0 commit comments

Comments
 (0)