Skip to content

Commit d9a0579

Browse files
committed
cmd/compile: disable flaky test
The test is inherently racy and vulnerable to starvation, and within all.bash on some platforms that means it flakes. Test is kept because it can be useful standalone to verify behavior of GOEXPERIMENT=preeemptibleloops, and there is likely to be further development of this feature in the future. There's also some question as to why it is flaking, because though technically this is permitted, it's very odd in this simple case. Fixes #18589. Change-Id: Ia0dd9037285c4a03122da4012c96981c9cc43b60 Reviewed-on: https://go-review.googlesource.com/35051 Run-TryBot: David Chase <[email protected]> TryBot-Result: Gobot Gobot <[email protected]> Reviewed-by: Russ Cox <[email protected]>
1 parent 2817e77 commit d9a0579

File tree

1 file changed

+12
-3
lines changed

1 file changed

+12
-3
lines changed

test/fixedbugs/issue10958.go

Lines changed: 12 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,21 @@
1-
// +build !nacl
2-
// buildrun -t 2 -gcflags=-d=ssa/insert_resched_checks/on,ssa/check/on
1+
// +build !nacl,disabled
2+
// buildrun -t 10 -gcflags=-d=ssa/insert_resched_checks/on,ssa/check/on
33

44
// Copyright 2016 The Go Authors. All rights reserved.
55
// Use of this source code is governed by a BSD-style
66
// license that can be found in the LICENSE file.
77

8+
// Test is disabled because it flakes when run in all.bash
9+
// on some platforms, but is useful standalone to verify
10+
// that rescheduling checks are working (and we may wish
11+
// to investigate the flake, since it suggests that the
12+
// loop rescheduling check may not work right on those
13+
// platforms).
14+
815
// This checks to see that call-free infinite loops do not
9-
// block garbage collection.
16+
// block garbage collection. IF YOU RUN IT STANDALONE without
17+
// -gcflags=-d=ssa/insert_resched_checks/on in a not-experimental
18+
// build, it should hang.
1019

1120
package main
1221

0 commit comments

Comments
 (0)