runtime: add debugging to TestTimePprof

aclements · aclements · commit d888f1d5c068 · 2020-10-02T18:57:36.000Z
We've seen timeouts of TestTimePprof, but the tracebacks aren't useful because goroutines are running on other threads. Add GOTRACEBACK=crash to catch these in the future. For #41120. Change-Id: I97318172ef78d0cbab10df5e4ffcbfeadff579e3 Reviewed-on: https://go-review.googlesource.com/c/go/+/258802 Trust: Austin Clements <austin@google.com> Run-TryBot: Austin Clements <austin@google.com> TryBot-Result: Go Bot <gobot@golang.org> Reviewed-by: Bryan C. Mills <bcmills@google.com>
diff --git a/src/runtime/crash_test.go b/src/runtime/crash_test.go
@@ -667,7 +667,9 @@ func TestBadTraceback(t *testing.T) {
 }
 
 func TestTimePprof(t *testing.T) {
-	fn := runTestProg(t, "testprog", "TimeProf")
+	// Pass GOTRACEBACK for issue #41120 to try to get more
+	// information on timeout.
+	fn := runTestProg(t, "testprog", "TimeProf", "GOTRACEBACK=crash")
 	fn = strings.TrimSpace(fn)
 	defer os.Remove(fn)
 

Original file line number	Diff line number	Diff line change
`@@ -667,7 +667,9 @@ func TestBadTraceback(t *testing.T) {`
`667`	`667`	`}`
`668`	`668`
`669`	`669`	`func TestTimePprof(t *testing.T) {`
`670`		`- fn := runTestProg(t, "testprog", "TimeProf")`
	`670`	`+ // Pass GOTRACEBACK for issue #41120 to try to get more`
	`671`	`+ // information on timeout.`
	`672`	`+ fn := runTestProg(t, "testprog", "TimeProf", "GOTRACEBACK=crash")`
`671`	`673`	`fn = strings.TrimSpace(fn)`
`672`	`674`	`defer os.Remove(fn)`
`673`	`675`