Skip to content

Commit d7d235c

Browse files
ianlancetaylormknyszek
authored andcommitted
runtime: permit core dumps in darwin-amd64
Previously we did not permit them as Go programs generated enormous core dumps on macOS. However, according to an investigation in #59446, they are OK now. For #59446 Change-Id: I1d7a3f500a6bc525aa6de8dfa8a1d8dbb15feadc Reviewed-on: https://go-review.googlesource.com/c/go/+/483015 TryBot-Result: Gopher Robot <[email protected]> Run-TryBot: Ian Lance Taylor <[email protected]> Reviewed-by: Michael Knyszek <[email protected]> Reviewed-by: Michael Pratt <[email protected]>
1 parent a3df6c0 commit d7d235c

File tree

1 file changed

+0
-10
lines changed

1 file changed

+0
-10
lines changed

src/runtime/signal_unix.go

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -973,16 +973,6 @@ func raisebadsignal(sig uint32, c *sigctxt) {
973973

974974
//go:nosplit
975975
func crash() {
976-
// OS X core dumps are linear dumps of the mapped memory,
977-
// from the first virtual byte to the last, with zeros in the gaps.
978-
// Because of the way we arrange the address space on 64-bit systems,
979-
// this means the OS X core file will be >128 GB and even on a zippy
980-
// workstation can take OS X well over an hour to write (uninterruptible).
981-
// Save users from making that mistake.
982-
if GOOS == "darwin" && GOARCH == "amd64" {
983-
return
984-
}
985-
986976
dieFromSignal(_SIGABRT)
987977
}
988978

0 commit comments

Comments
 (0)