Skip to content

Commit d4df6f4

Browse files
committed
net/http: updated bundled http2 copy, enable some tests
Updates bundled copy of x/net/http2 to include https://golang.org/cl/17823 (catching panics in Handlers) Fixes #13555 Change-Id: I08e4e38e736a8d93f5ec200e8041c143fc6eafce Reviewed-on: https://go-review.googlesource.com/17824 Reviewed-by: Ian Lance Taylor <[email protected]> Run-TryBot: Brad Fitzpatrick <[email protected]> TryBot-Result: Gobot Gobot <[email protected]>
1 parent 9b1068a commit d4df6f4

File tree

2 files changed

+45
-12
lines changed

2 files changed

+45
-12
lines changed

src/net/http/h2_bundle.go

Lines changed: 44 additions & 7 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/net/http/serve_test.go

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1926,16 +1926,12 @@ func testZeroLengthPostAndResponse(t *testing.T, h2 bool) {
19261926
}
19271927

19281928
func TestHandlerPanicNil_h1(t *testing.T) { testHandlerPanic(t, false, h1Mode, nil) }
1929-
func TestHandlerPanicNil_h2(t *testing.T) {
1930-
t.Skip("known failure; golang.org/issue/13555")
1931-
testHandlerPanic(t, false, h2Mode, nil)
1932-
}
1929+
func TestHandlerPanicNil_h2(t *testing.T) { testHandlerPanic(t, false, h2Mode, nil) }
19331930

19341931
func TestHandlerPanic_h1(t *testing.T) {
19351932
testHandlerPanic(t, false, h1Mode, "intentional death for testing")
19361933
}
19371934
func TestHandlerPanic_h2(t *testing.T) {
1938-
t.Skip("known failure; golang.org/issue/13555")
19391935
testHandlerPanic(t, false, h2Mode, "intentional death for testing")
19401936
}
19411937

0 commit comments

Comments
 (0)