Skip to content

Commit d045976

Browse files
prattmicgopherbot
authored andcommitted
runtime: update skips for TestGdbBacktrace
One issue simply has a reworded message, probably from a new version of GDB. Another is a new issue. Fixes #60553. Fixes #58698. Updates #39204. Change-Id: I8389aa981fab5421f57ee761bfb5e1dd237709ed Reviewed-on: https://go-review.googlesource.com/c/go/+/499975 Reviewed-by: Bryan Mills <[email protected]> Run-TryBot: Michael Pratt <[email protected]> Auto-Submit: Michael Pratt <[email protected]> TryBot-Result: Gopher Robot <[email protected]> Reviewed-by: Austin Clements <[email protected]>
1 parent fdb3dc4 commit d045976

File tree

1 file changed

+7
-5
lines changed

1 file changed

+7
-5
lines changed

src/runtime/runtime-gdb_test.go

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -470,15 +470,17 @@ func TestGdbBacktrace(t *testing.T) {
470470
got, err := cmd.CombinedOutput()
471471
t.Logf("gdb output:\n%s", got)
472472
if err != nil {
473-
if bytes.Contains(got, []byte("internal-error: wait returned unexpected status 0x0")) {
473+
switch {
474+
case bytes.Contains(got, []byte("internal-error: wait returned unexpected status 0x0")):
474475
// GDB bug: https://sourceware.org/bugzilla/show_bug.cgi?id=28551
475476
testenv.SkipFlaky(t, 43068)
476-
}
477-
if bytes.Contains(got, []byte("Couldn't get registers: No such process.")) {
477+
case bytes.Contains(got, []byte("Couldn't get registers: No such process.")), bytes.Contains(got, []byte("Unable to fetch general registers.: No such process.")):
478478
// GDB bug: https://sourceware.org/bugzilla/show_bug.cgi?id=9086
479479
testenv.SkipFlaky(t, 50838)
480-
}
481-
if bytes.Contains(got, []byte(" exited normally]\n")) {
480+
case bytes.Contains(got, []byte("waiting for new child: No child processes.")):
481+
// GDB bug: Sometimes it fails to wait for a clone child.
482+
testenv.SkipFlaky(t, 60553)
483+
case bytes.Contains(got, []byte(" exited normally]\n")):
482484
// GDB bug: Sometimes the inferior exits fine,
483485
// but then GDB hangs.
484486
testenv.SkipFlaky(t, 37405)

0 commit comments

Comments
 (0)