Skip to content

Commit d0006e7

Browse files
net: use newLocalListener in TestClosingListener.
Updates #21856 Change-Id: I9baa51fe23e6dd2fcf9dd14f7acfaf7457571e1d Reviewed-on: https://go-review.googlesource.com/66334 Run-TryBot: Ian Lance Taylor <[email protected]> TryBot-Result: Gobot Gobot <[email protected]> Reviewed-by: David Crawshaw <[email protected]> Reviewed-by: Mikio Hara <[email protected]>
1 parent 1591dad commit d0006e7

File tree

1 file changed

+7
-6
lines changed

1 file changed

+7
-6
lines changed

src/net/listen_test.go

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -700,15 +700,15 @@ func multicastRIBContains(ip IP) (bool, error) {
700700

701701
// Issue 21856.
702702
func TestClosingListener(t *testing.T) {
703-
listener, err := Listen("tcp", ":0")
703+
ln, err := newLocalListener("tcp")
704704
if err != nil {
705705
t.Fatal(err)
706706
}
707-
addr := listener.Addr()
707+
addr := ln.Addr()
708708

709709
go func() {
710710
for {
711-
c, err := listener.Accept()
711+
c, err := ln.Accept()
712712
if err != nil {
713713
return
714714
}
@@ -721,10 +721,11 @@ func TestClosingListener(t *testing.T) {
721721
// testing anything, which is OK.
722722
time.Sleep(time.Millisecond)
723723

724-
listener.Close()
724+
ln.Close()
725725

726-
_, err = Listen("tcp", addr.String())
726+
ln, err = Listen("tcp", addr.String())
727727
if err != nil {
728-
t.Error(err)
728+
t.Fatal(err)
729729
}
730+
ln.Close()
730731
}

0 commit comments

Comments
 (0)