Skip to content

Commit c46226a

Browse files
committed
net: mark TestDialerDualStack as flaky
It was already marked flaky for everything but the dashboard. Remove that restriction. It's just flaky overall. It's doing more harm than good. Updates #13324 Change-Id: I36feff32a1b8681e77700f74b9c70cb4073268eb Reviewed-on: https://go-review.googlesource.com/38459 Run-TryBot: Brad Fitzpatrick <[email protected]> TryBot-Result: Gobot Gobot <[email protected]> Reviewed-by: Josh Bleecher Snyder <[email protected]>
1 parent b5e1ae4 commit c46226a

File tree

1 file changed

+2
-5
lines changed

1 file changed

+2
-5
lines changed

src/net/dial_test.go

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -715,11 +715,8 @@ func TestDialerLocalAddr(t *testing.T) {
715715
}
716716

717717
func TestDialerDualStack(t *testing.T) {
718-
// This test is known to be flaky. Don't frighten regular
719-
// users about it; only fail on the build dashboard.
720-
if testenv.Builder() == "" {
721-
testenv.SkipFlaky(t, 13324)
722-
}
718+
testenv.SkipFlaky(t, 13324)
719+
723720
if !supportsIPv4 || !supportsIPv6 {
724721
t.Skip("both IPv4 and IPv6 are required")
725722
}

0 commit comments

Comments
 (0)