Skip to content

Commit c2a2fba

Browse files
Bryan C. Millsprattmic
Bryan C. Mills
authored andcommitted
[release-branch.go1.19] cmd/go: skip TestScript/mod_replace_gopkgin
(Until it can be made hermetic.) The gopkg.in service has had a lot of flakiness lately. Go users in general are isolated from that flakiness by the Go module mirror (proxy.golang.org), but this test intentionally bypasses the module mirror because the mirror itself uses cmd/go to download the module. In the long term, we can redirect the gopkg.in URL to the local (in-process) vcweb server added for #27494. In the meantime, let's skip the test to reduce the impact of upstream outages. Fixes #57058. Updates #54503. Change-Id: Icf3de7ca416db548e53864a71776fe22b444fcea Reviewed-on: https://go-review.googlesource.com/c/go/+/454503 Run-TryBot: Bryan Mills <[email protected]> Auto-Submit: Bryan Mills <[email protected]> TryBot-Result: Gopher Robot <[email protected]> Reviewed-by: Heschi Kreinick <[email protected]> (cherry picked from commit c5f5cb659adda026d01b7fa9bd39b2ad3b58c5bf) Reviewed-on: https://go-review.googlesource.com/c/go/+/454839 Reviewed-by: Michael Pratt <[email protected]>
1 parent 1565780 commit c2a2fba

File tree

1 file changed

+3
-0
lines changed

1 file changed

+3
-0
lines changed

src/cmd/go/testdata/script/mod_replace_gopkgin.txt

+3
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,9 @@
44
# even if there is an explicit go.mod file containing the
55
# gopkg.in path.
66

7+
skip 'skipping test that depends on an unreliable third-party server; see https://go.dev/issue/54503'
8+
# TODO(#54043): Make this test hermetic and re-enable it.
9+
710
[short] skip
811
[!net] skip
912
[!exec:git] skip

0 commit comments

Comments
 (0)