Skip to content

Commit c20bcb6

Browse files
committed
runtime: remove out-of-date comments about frame skipping
skipPleaseUseCallersFrames was removed in CL 152537. Change-Id: Ide47feec85a33a6fb6882e16baf9e21492521640 Reviewed-on: https://go-review.googlesource.com/c/go/+/325949 Trust: Matthew Dempsky <[email protected]> Run-TryBot: Matthew Dempsky <[email protected]> TryBot-Result: Go Bot <[email protected]> Reviewed-by: Keith Randall <[email protected]>
1 parent 39c39ae commit c20bcb6

File tree

1 file changed

+1
-5
lines changed

1 file changed

+1
-5
lines changed

src/runtime/traceback.go

+1-5
Original file line numberDiff line numberDiff line change
@@ -56,18 +56,14 @@ func tracebackdefers(gp *g, callback func(*stkframe, unsafe.Pointer) bool, v uns
5656
}
5757
}
5858

59-
const sizeofSkipFunction = 256
60-
6159
// Generic traceback. Handles runtime stack prints (pcbuf == nil),
6260
// the runtime.Callers function (pcbuf != nil), as well as the garbage
6361
// collector (callback != nil). A little clunky to merge these, but avoids
6462
// duplicating the code and all its subtlety.
6563
//
6664
// The skip argument is only valid with pcbuf != nil and counts the number
6765
// of logical frames to skip rather than physical frames (with inlining, a
68-
// PC in pcbuf can represent multiple calls). If a PC is partially skipped
69-
// and max > 1, pcbuf[1] will be runtime.skipPleaseUseCallersFrames+N where
70-
// N indicates the number of logical frames to skip in pcbuf[0].
66+
// PC in pcbuf can represent multiple calls).
7167
func gentraceback(pc0, sp0, lr0 uintptr, gp *g, skip int, pcbuf *uintptr, max int, callback func(*stkframe, unsafe.Pointer) bool, v unsafe.Pointer, flags uint) int {
7268
if skip > 0 && callback != nil {
7369
throw("gentraceback callback cannot be used with non-zero skip")

0 commit comments

Comments
 (0)