Skip to content

Commit bec8a10

Browse files
author
Bryan C. Mills
committed
runtime: skip TestSegv failures with "morestack on g0" on darwin/amd64
This failure mode has been present since at least 2020-06-08. We have enough information to diagnose it, and further failures don't seem to be adding any new information at this point: they can only add noise, both on the Go project's builders and in users' own modules (for example, when run as part of 'go test all'). For #39457 Change-Id: I2379631da0c8af69598fa61c0cc5ac0ea6ba8267 Reviewed-on: https://go-review.googlesource.com/c/go/+/382395 Trust: Bryan Mills <[email protected]> Run-TryBot: Bryan Mills <[email protected]> TryBot-Result: Gopher Robot <[email protected]> Reviewed-by: Cherry Mui <[email protected]>
1 parent fa4d9b8 commit bec8a10

File tree

1 file changed

+3
-0
lines changed

1 file changed

+3
-0
lines changed

src/runtime/crash_cgo_test.go

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -596,6 +596,9 @@ func TestSegv(t *testing.T) {
596596
t.Log(got)
597597
want := "SIGSEGV"
598598
if !strings.Contains(got, want) {
599+
if runtime.GOOS == "darwin" && runtime.GOARCH == "amd64" && strings.Contains(got, "fatal: morestack on g0") {
600+
testenv.SkipFlaky(t, 39457)
601+
}
599602
t.Errorf("did not see %q in output", want)
600603
}
601604

0 commit comments

Comments
 (0)