cmd/link/internal/ld: add missing Close

eliasnaur · eliasnaur · commit bc588d4d921b · 2019-05-08T13:58:24.000Z
Noticed while working on issue 30488. Change-Id: Ia3655e07c939d03925b3560eeba24c60e24c136c Reviewed-on: https://go-review.googlesource.com/c/go/+/175917 Run-TryBot: Elias Naur <mail@eliasnaur.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
diff --git a/src/cmd/link/internal/ld/macho_combine_dwarf.go b/src/cmd/link/internal/ld/macho_combine_dwarf.go
@@ -99,6 +99,7 @@ func machoCombineDwarf(ctxt *Link, exef *os.File, exem *macho.File, dsym, outexe
 	if err != nil {
 		return err
 	}
+	defer dwarff.Close()
 	outf, err := os.Create(outexe)
 	if err != nil {
 		return err

Original file line number	Diff line number	Diff line change
`@@ -99,6 +99,7 @@ func machoCombineDwarf(ctxt Link, exef os.File, exem *macho.File, dsym, outexe`
`99`	`99`	`if err != nil {`
`100`	`100`	`return err`
`101`	`101`	`}`
	`102`	`+ defer dwarff.Close()`
`102`	`103`	`outf, err := os.Create(outexe)`
`103`	`104`	`if err != nil {`
`104`	`105`	`return err`