Skip to content

Commit b146d76

Browse files
neildgopherbot
authored andcommitted
Revert "io: detect Writers that access io.Copy's buffer after returning"
This reverts CL 466865. Reason for revert: Causing trybot flakiness due to net/http race, roll back until net/http is fixed. For #58168 Change-Id: I3129deb996abe6466eccf933fe93cbbaf72ae217 Reviewed-on: https://go-review.googlesource.com/c/go/+/467895 TryBot-Result: Gopher Robot <[email protected]> Auto-Submit: Damien Neil <[email protected]> Reviewed-by: Bryan Mills <[email protected]> Run-TryBot: Damien Neil <[email protected]>
1 parent 0cd309e commit b146d76

File tree

1 file changed

+0
-9
lines changed

1 file changed

+0
-9
lines changed

src/io/io.go

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,6 @@ package io
1414

1515
import (
1616
"errors"
17-
"internal/race"
1817
"sync"
1918
)
2019

@@ -428,14 +427,6 @@ func copyBuffer(dst Writer, src Reader, buf []byte) (written int64, err error) {
428427
nr, er := src.Read(buf)
429428
if nr > 0 {
430429
nw, ew := dst.Write(buf[0:nr])
431-
if race.Enabled {
432-
// Write over the buffer to help the race detector
433-
// detect Write calls that access the buffer after returning.
434-
// Use something other than zeros to make errors more obvious.
435-
for i := range buf[:nr] {
436-
buf[i] = 0xdd
437-
}
438-
}
439430
if nw < 0 || nr < nw {
440431
nw = 0
441432
if ew == nil {

0 commit comments

Comments
 (0)