Skip to content

Commit b098c0f

Browse files
committed
cmd/compile/internal/ppc64: improve naming for ginsnop2
This is a follow up from a review comment at the end of the last Go release, to provide a more meaningful name for ginsnop2. Updates #30475 Change-Id: Ice9efd763bf2204a9e8c55ae230d3e8a80210108 Reviewed-on: https://go-review.googlesource.com/c/go/+/174757 Run-TryBot: Lynn Boger <[email protected]> TryBot-Result: Gobot Gobot <[email protected]> Reviewed-by: Keith Randall <[email protected]>
1 parent ab5cee5 commit b098c0f

File tree

2 files changed

+4
-3
lines changed

2 files changed

+4
-3
lines changed

src/cmd/compile/internal/ppc64/galign.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ func Init(arch *gc.Arch) {
2121
arch.ZeroRange = zerorange
2222
arch.ZeroAuto = zeroAuto
2323
arch.Ginsnop = ginsnop
24-
arch.Ginsnopdefer = ginsnop2
24+
arch.Ginsnopdefer = ginsnopdefer
2525

2626
arch.SSAMarkMoves = ssaMarkMoves
2727
arch.SSAGenValue = ssaGenValue

src/cmd/compile/internal/ppc64/ggen.go

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -67,8 +67,9 @@ func ginsnop(pp *gc.Progs) *obj.Prog {
6767
return p
6868
}
6969

70-
func ginsnop2(pp *gc.Progs) *obj.Prog {
71-
// PPC64 is unusual because TWO nops are required
70+
func ginsnopdefer(pp *gc.Progs) *obj.Prog {
71+
// On PPC64 two nops are required in the defer case.
72+
//
7273
// (see gc/cgen.go, gc/plive.go -- copy of comment below)
7374
//
7475
// On ppc64, when compiling Go into position

0 commit comments

Comments
 (0)