Skip to content

Commit a99c38d

Browse files
committed
Revert "cmd/dist: log CPU model when testing"
Fails TestRepeatBootstrap. This reverts CL 371474. For #50146. Change-Id: Ie4adda4e0229e153471301ca00fe2c1c694b4b2d Reviewed-on: https://go-review.googlesource.com/c/go/+/378587 Reviewed-by: Bryan Mills <[email protected]> Reviewed-by: Ian Lance Taylor <[email protected]> Trust: Michael Pratt <[email protected]> Run-TryBot: Michael Pratt <[email protected]> TryBot-Result: Gopher Robot <[email protected]>
1 parent 07b995e commit a99c38d

File tree

4 files changed

+3
-67
lines changed

4 files changed

+3
-67
lines changed

src/cmd/dist/metadata.go

-24
This file was deleted.

src/cmd/dist/metadata_bootstrap.go

-21
This file was deleted.

src/cmd/dist/sys_windows.go

+3-3
Original file line numberDiff line numberDiff line change
@@ -38,11 +38,11 @@ const (
3838
PROCESSOR_ARCHITECTURE_IA64 = 6
3939
)
4040

41-
var winsysinfo systeminfo
41+
var sysinfo systeminfo
4242

4343
func sysinit() {
44-
syscall.Syscall(procGetSystemInfo.Addr(), 1, uintptr(unsafe.Pointer(&winsysinfo)), 0, 0)
45-
switch winsysinfo.wProcessorArchitecture {
44+
syscall.Syscall(procGetSystemInfo.Addr(), 1, uintptr(unsafe.Pointer(&sysinfo)), 0, 0)
45+
switch sysinfo.wProcessorArchitecture {
4646
case PROCESSOR_ARCHITECTURE_AMD64:
4747
gohostarch = "amd64"
4848
case PROCESSOR_ARCHITECTURE_INTEL:

src/cmd/dist/test.go

-19
Original file line numberDiff line numberDiff line change
@@ -218,15 +218,6 @@ func (t *tester) run() {
218218
}
219219
}
220220

221-
if err := t.maybeLogMetadata(); err != nil {
222-
t.failed = true
223-
if t.keepGoing {
224-
log.Printf("Failed logging metadata: %v", err)
225-
} else {
226-
fatalf("Failed logging metadata: %v", err)
227-
}
228-
}
229-
230221
for _, dt := range t.tests {
231222
if !t.shouldRunTest(dt.name) {
232223
t.partial = true
@@ -277,16 +268,6 @@ func (t *tester) shouldRunTest(name string) bool {
277268
return false
278269
}
279270

280-
func (t *tester) maybeLogMetadata() error {
281-
if t.compileOnly {
282-
// We need to run a subprocess to log metadata. Don't do that
283-
// on compile-only runs.
284-
return nil
285-
}
286-
t.out("Test execution environment.")
287-
return logMetadata()
288-
}
289-
290271
// short returns a -short flag value to use with 'go test'
291272
// or a test binary for tests intended to run in short mode.
292273
// It returns "true", unless the environment variable

0 commit comments

Comments
 (0)