Skip to content

Commit a84b18a

Browse files
ianlancetaylorbradfitz
authored andcommitted
Revert "regexp: add the Fanout benchmark
This is a copy of the "FANOUT" benchmark recently added to RE2 with the following comment: // This has quite a high degree of fanout. // NFA execution will be particularly slow. Most of the benchmarks on the regexp package have very little fanout and are designed for comparing the regexp package's NFA with backtracking engines found in other regular expression libraries. This benchmark exercises the performance of the NFA on expressions with high fanout.Reviewed-on: https://go-review.googlesource.com/24846 Reviewed-by: Andrew Gerrand <[email protected]> Reviewed-by: Ian Lance Taylor <[email protected]> " This reverts commit fc80387. Reason for revert: Breaks the -race build because the benchmark takes too long to run. Change-Id: I6ed4b466f74a4108d8bcd5b019b9abe971eb483e Reviewed-on: https://go-review.googlesource.com/24861 Run-TryBot: Ian Lance Taylor <[email protected]> Reviewed-by: Josh Bleecher Snyder <[email protected]> TryBot-Result: Gobot Gobot <[email protected]> Reviewed-by: Michael Matloob <[email protected]>
1 parent fc80387 commit a84b18a

File tree

1 file changed

+0
-1
lines changed

1 file changed

+0
-1
lines changed

src/regexp/exec_test.go

-1
Original file line numberDiff line numberDiff line change
@@ -682,7 +682,6 @@ var benchData = []struct{ name, re string }{
682682
{"Medium", "[XYZ]ABCDEFGHIJKLMNOPQRSTUVWXYZ$"},
683683
{"Hard", "[ -~]*ABCDEFGHIJKLMNOPQRSTUVWXYZ$"},
684684
{"Hard1", "ABCD|CDEF|EFGH|GHIJ|IJKL|KLMN|MNOP|OPQR|QRST|STUV|UVWX|WXYZ"},
685-
{"Fanout", "(?:[\\x{80}-\\x{10FFFF}]?){100}[\\x{80}-\\x{10FFFF}]"},
686685
}
687686

688687
var benchSizes = []struct {

0 commit comments

Comments
 (0)