Skip to content

Commit 9f51325

Browse files
committed
net: skip DNS tests on self-hosted Android
They were already skipped on tethered Android builders because the tests are gated on GO_BUILDER_NAME being set and the Android exec wrapper does not propagate GO_BUILDER_NAME. Updates #31722 Change-Id: Ifd2c7daecc19a4e540d86d1f38083f43cc3e6b15 Reviewed-on: https://go-review.googlesource.com/c/go/+/175177 Run-TryBot: Elias Naur <[email protected]> TryBot-Result: Gobot Gobot <[email protected]> Reviewed-by: Ian Lance Taylor <[email protected]>
1 parent bd384d4 commit 9f51325

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

src/net/dial_test.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -973,11 +973,11 @@ func TestDialerControl(t *testing.T) {
973973
}
974974

975975
// mustHaveExternalNetwork is like testenv.MustHaveExternalNetwork
976-
// except that it won't skip testing on non-iOS builders.
976+
// except that it won't skip testing on non-mobile builders.
977977
func mustHaveExternalNetwork(t *testing.T) {
978978
t.Helper()
979-
ios := runtime.GOOS == "darwin" && (runtime.GOARCH == "arm" || runtime.GOARCH == "arm64")
980-
if testenv.Builder() == "" || ios {
979+
mobile := runtime.GOOS == "android" || runtime.GOOS == "darwin" && (runtime.GOARCH == "arm" || runtime.GOARCH == "arm64")
980+
if testenv.Builder() == "" || mobile {
981981
testenv.MustHaveExternalNetwork(t)
982982
}
983983
}

0 commit comments

Comments
 (0)