Skip to content

Commit 9c6ecc4

Browse files
author
Bryan C. Mills
committed
runtime: skip known TestSegv failure mode on linux-mips64le-mengzhuo
Also adjust other skips to actually call t.Skip, so that the test correctly shows as skipped instead of passing. For #50605 Change-Id: Ied482f231a879224c5a92e2c47a6b21c1593a7da Reviewed-on: https://go-review.googlesource.com/c/go/+/378554 Trust: Bryan Mills <[email protected]> Reviewed-by: Michael Pratt <[email protected]> Run-TryBot: Bryan Mills <[email protected]> TryBot-Result: Gopher Robot <[email protected]>
1 parent 17b2fb1 commit 9c6ecc4

File tree

1 file changed

+11
-9
lines changed

1 file changed

+11
-9
lines changed

src/runtime/crash_cgo_test.go

Lines changed: 11 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -622,17 +622,19 @@ func TestSegv(t *testing.T) {
622622
// No runtime errors like "runtime: unknown pc".
623623
switch runtime.GOOS {
624624
case "darwin", "illumos", "solaris":
625-
// TODO(golang.org/issue/49182): Skip, runtime
626-
// throws while attempting to generate
627-
// traceback.
628-
return
625+
// Runtime sometimes throws when generating the traceback.
626+
testenv.SkipFlaky(t, 49182)
629627
case "linux":
630628
if runtime.GOARCH == "386" {
631-
// TODO(golang.org/issue/50504): Skip,
632-
// runtime throws while attempting to
633-
// generate traceback from VDSO call
634-
// via asmcgocall.
635-
return
629+
// Runtime throws when generating a traceback from
630+
// a VDSO call via asmcgocall.
631+
testenv.SkipFlaky(t, 50504)
632+
}
633+
if testenv.Builder() == "linux-mips64le-mengzhuo" && strings.Contains(got, "runtime: unknown pc") {
634+
// Runtime sometimes throw "unknown pc" when generating the traceback.
635+
// Curiously, that doesn't seem to happen on the linux-mips64le-rtrk
636+
// builder.
637+
testenv.SkipFlaky(t, 50605)
636638
}
637639
}
638640
nowant := "runtime: "

0 commit comments

Comments
 (0)