flag: remove "// BUG" comment

zamicol · gopherbot · commit 9abcc487f8b0 · 2022-10-17T14:50:31.000Z
Remove a vestigial " // BUG" comment as there is no bug in the relevant code section and comment predated other changes. Also removed a needless allocation and conformed to the "v, ok := a[x]" standard convention. Tests are passing. Change-Id: Id28ad1baf77447052b54b341f018e573bac0c11a GitHub-Last-Rev: 2608469 GitHub-Pull-Request: #56210 Reviewed-on: https://go-review.googlesource.com/c/go/+/442815 Reviewed-by: Ian Lance Taylor <iant@google.com> Reviewed-by: David Chase <drchase@google.com> Auto-Submit: Ian Lance Taylor <iant@google.com> Run-TryBot: Ian Lance Taylor <iant@google.com> Reviewed-by: Rob Pike <r@golang.org> TryBot-Result: Gopher Robot <gobot@golang.org>
diff --git a/src/flag/flag.go b/src/flag/flag.go
@@ -1056,9 +1056,9 @@ func (f *FlagSet) parseOne() (bool, error) {
 			break
 		}
 	}
-	m := f.formal
-	flag, alreadythere := m[name] // BUG
-	if !alreadythere {
+
+	flag, ok := f.formal[name]
+	if !ok {
 		if name == "help" || name == "h" { // special case for nice help message.
 			f.usage()
 			return false, ErrHelp

Original file line number	Diff line number	Diff line change
`@@ -1056,9 +1056,9 @@ func (f *FlagSet) parseOne() (bool, error) {`
`1056`	`1056`	`break`
`1057`	`1057`	`}`
`1058`	`1058`	`}`
`1059`		`- m := f.formal`
`1060`		`- flag, alreadythere := m[name] // BUG`
`1061`		`- if !alreadythere {`
	`1059`	`+`
	`1060`	`+ flag, ok := f.formal[name]`
	`1061`	`+ if !ok {`
`1062`	`1062`	`if name == "help" \|\| name == "h" { // special case for nice help message.`
`1063`	`1063`	`f.usage()`
`1064`	`1064`	`return false, ErrHelp`