Skip to content

Commit 9a7278a

Browse files
author
Jay Conrod
committed
cmd/go: fix failure in TestScript/build_runtime_gcflags
This test case failed on the longtest builder. It relied on runtime/internal/atomic not being compiled with the -l flag in the cache. The test case now creates its own GOCACHE, similar to build_cache_compile and a few others. Also, mention the correct issue the test case verifies. Fixes #29395 Change-Id: Id50e9dfc50db03fb11582d3dd6b69c3e1ed750eb Reviewed-on: https://go-review.googlesource.com/c/156237 Run-TryBot: Jay Conrod <[email protected]> TryBot-Result: Gobot Gobot <[email protected]> Reviewed-by: Ian Lance Taylor <[email protected]>
1 parent af134b1 commit 9a7278a

File tree

1 file changed

+6
-2
lines changed

1 file changed

+6
-2
lines changed
Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,8 @@
1-
# This test verifies the standard library (specifically runtime/internal/atomic)
2-
# can be built with -gcflags when -n is given. See golang.org/issue/26092.
1+
# Set up fresh GOCACHE.
2+
env GOCACHE=$WORK/gocache
3+
mkdir $GOCACHE
4+
5+
# Verify the standard library (specifically runtime/internal/atomic) can be
6+
# built with -gcflags when -n is given. See golang.org/issue/29346.
37
go build -n -gcflags=all='-l' std
48
stderr 'compile.* -l .* runtime/internal/atomic'

0 commit comments

Comments
 (0)