Skip to content

Commit 9a71015

Browse files
komuwandybons
authored andcommitted
runtime/pprof: document labels bug
Currently only CPU profile utilizes tag information. This change documents that fact Updates #23458 Change-Id: Ic893e85f63af0da9100d8cba7d3328c294e8c810 GitHub-Last-Rev: be99a12 GitHub-Pull-Request: #27198 Reviewed-on: https://go-review.googlesource.com/c/go/+/131275 Reviewed-by: Hyang-Ah Hana Kim <[email protected]>
1 parent 91170d7 commit 9a71015

File tree

1 file changed

+2
-0
lines changed

1 file changed

+2
-0
lines changed

src/runtime/pprof/label.go

+2
Original file line numberDiff line numberDiff line change
@@ -54,6 +54,8 @@ func WithLabels(ctx context.Context, labels LabelSet) context.Context {
5454
// Labels takes an even number of strings representing key-value pairs
5555
// and makes a LabelSet containing them.
5656
// A label overwrites a prior label with the same key.
57+
// Currently only CPU profile utilizes labels information.
58+
// See https://golang.org/issue/23458 for details.
5759
func Labels(args ...string) LabelSet {
5860
if len(args)%2 != 0 {
5961
panic("uneven number of arguments to pprof.Labels")

0 commit comments

Comments
 (0)