Skip to content

Commit 9a2001a

Browse files
ianlancetaylorgopherbot
authored andcommitted
cmd/dist: always pass -short=true with -quick
Fixes #53818 Change-Id: I190a8bcf50d92b9c10e9980e630ebb362d8b19ec Reviewed-on: https://go-review.googlesource.com/c/go/+/417918 Run-TryBot: Ian Lance Taylor <[email protected]> Auto-Submit: Ian Lance Taylor <[email protected]> TryBot-Result: Gopher Robot <[email protected]> Reviewed-by: Michael Pratt <[email protected]> Run-TryBot: Ian Lance Taylor <[email protected]> Reviewed-by: Cherry Mui <[email protected]>
1 parent 5c8ec89 commit 9a2001a

File tree

2 files changed

+7
-2
lines changed

2 files changed

+7
-2
lines changed

src/cmd/dist/test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -542,7 +542,7 @@ func (t *tester) registerTests() {
542542
name: testName,
543543
heading: "GOMAXPROCS=2 runtime -cpu=1,2,4 -quick",
544544
fn: func(dt *distTest) error {
545-
cmd := t.addCmd(dt, "src", t.goTest(), t.timeout(300), "runtime", "-cpu=1,2,4", "-quick")
545+
cmd := t.addCmd(dt, "src", t.goTest(), "-short=true", t.timeout(300), "runtime", "-cpu=1,2,4", "-quick")
546546
// We set GOMAXPROCS=2 in addition to -cpu=1,2,4 in order to test runtime bootstrap code,
547547
// creation of first goroutines and first garbage collections in the parallel setting.
548548
setEnv(cmd, "GOMAXPROCS", "2")

src/runtime/runtime_test.go

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,12 @@ import (
1818
"unsafe"
1919
)
2020

21-
var flagQuick = flag.Bool("quick", false, "skip slow tests, for second run in all.bash")
21+
// flagQuick is set by the -quick option to skip some relatively slow tests.
22+
// This is used by the cmd/dist test runtime:cpu124.
23+
// The cmd/dist test passes both -test.short and -quick;
24+
// there are tests that only check testing.Short, and those tests will
25+
// not be skipped if only -quick is used.
26+
var flagQuick = flag.Bool("quick", false, "skip slow tests, for cmd/dist test runtime:cpu124")
2227

2328
func init() {
2429
// We're testing the runtime, so make tracebacks show things

0 commit comments

Comments
 (0)