Skip to content

Commit 8ffcd3d

Browse files
cuonglmgopherbot
authored andcommitted
cmd/compile: remove reflectdata.AfterGlobalEscapeAnalysis
This global variable was used by the old frontend to decide whether to perform escape analysis during method wrapper generation. The old frontend is gone now, the variable is not used anywhere else. Change-Id: I448f2761ea608a9a2ec39a9920fcf7aa12d98799 Reviewed-on: https://go-review.googlesource.com/c/go/+/466278 Reviewed-by: Matthew Dempsky <[email protected]> Run-TryBot: Cuong Manh Le <[email protected]> Reviewed-by: Keith Randall <[email protected]> Auto-Submit: Cuong Manh Le <[email protected]> TryBot-Result: Gopher Robot <[email protected]>
1 parent 3161081 commit 8ffcd3d

File tree

2 files changed

+0
-11
lines changed

2 files changed

+0
-11
lines changed

src/cmd/compile/internal/gc/main.go

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -293,11 +293,6 @@ func Main(archInit func(*ssagen.ArchInfo)) {
293293
base.Timer.Start("fe", "escapes")
294294
escape.Funcs(typecheck.Target.Decls)
295295

296-
// TODO(mdempsky): This is a hack. We need a proper, global work
297-
// queue for scheduling function compilation so components don't
298-
// need to adjust their behavior depending on when they're called.
299-
reflectdata.AfterGlobalEscapeAnalysis = true
300-
301296
// Collect information for go:nowritebarrierrec
302297
// checking. This must happen before transforming closures during Walk
303298
// We'll do the final check after write barriers are

src/cmd/compile/internal/reflectdata/reflect.go

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1869,12 +1869,6 @@ func methodWrapper(rcvr *types.Type, method *types.Field, forItab bool) *obj.LSy
18691869
return lsym
18701870
}
18711871

1872-
// AfterGlobalEscapeAnalysis tracks whether package gc has already
1873-
// performed the main, global escape analysis pass. If so,
1874-
// methodWrapper takes responsibility for escape analyzing any
1875-
// generated wrappers.
1876-
var AfterGlobalEscapeAnalysis bool
1877-
18781872
var ZeroSize int64
18791873

18801874
// MarkTypeUsedInInterface marks that type t is converted to an interface.

0 commit comments

Comments
 (0)