Skip to content

Commit 8e3930f

Browse files
mknyszekgopherbot
authored andcommitted
runtime: skip TestRuntimeLockMetricsAndProfile for flakiness
This test was added to check new mutex profile functionality. Specifically, it checks to make sure that the functionality behind GODEBUG=runtimecontentionstacks works. The runtime currently tracks contention from runtime-internal mutexes in mutex profiles, but it does not record stack traces for them, attributing the time to a dummy symbol. This GODEBUG enables collecting stacks. Just disable the test. Even if this functionality breaks, it won't affect Go users and it'll help keep the builders green. It's fine to leave the test because this will be revisited in the next dev cycle. For #64253. Change-Id: I7938fe0f036fc4e4a0764f030e691e312ec2c9b5 Reviewed-on: https://go-review.googlesource.com/c/go/+/550775 LUCI-TryBot-Result: Go LUCI <[email protected]> Reviewed-by: Eli Bendersky <[email protected]> Reviewed-by: Cherry Mui <[email protected]> Auto-Submit: Michael Knyszek <[email protected]>
1 parent 9b4b3e5 commit 8e3930f

File tree

1 file changed

+3
-0
lines changed

1 file changed

+3
-0
lines changed

src/runtime/metrics_test.go

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@ import (
99
"fmt"
1010
"internal/goexperiment"
1111
"internal/profile"
12+
"internal/testenv"
1213
"os"
1314
"reflect"
1415
"runtime"
@@ -947,6 +948,8 @@ func TestSchedPauseMetrics(t *testing.T) {
947948
}
948949

949950
func TestRuntimeLockMetricsAndProfile(t *testing.T) {
951+
testenv.SkipFlaky(t, 64253)
952+
950953
old := runtime.SetMutexProfileFraction(0) // enabled during sub-tests
951954
defer runtime.SetMutexProfileFraction(old)
952955
if old != 0 {

0 commit comments

Comments
 (0)