Skip to content

Commit 8d881b8

Browse files
committed
cmd/asm: correct, complete newly added AVX instructions
Use the standard names, for discoverability. Use the standard register arguments, for correctness. Implement all possible arguments, for completeness. Enable the corresponding tests now that everything is standard. Update the uses in package runtime. Fixes #14068. Change-Id: I8e1af9a41e7d02d98c2a82af3d4cdb3e9204824f Reviewed-on: https://go-review.googlesource.com/18852 Run-TryBot: Russ Cox <[email protected]> TryBot-Result: Gobot Gobot <[email protected]> Reviewed-by: Rob Pike <[email protected]>
1 parent 7f620a5 commit 8d881b8

File tree

6 files changed

+415
-333
lines changed

6 files changed

+415
-333
lines changed

src/cmd/asm/internal/asm/testdata/amd64enc.s

Lines changed: 144 additions & 144 deletions
Large diffs are not rendered by default.

src/cmd/internal/obj/x86/a.out.go

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -551,6 +551,7 @@ const (
551551
AFXRSTOR64
552552
AFXSAVE
553553
AFXSAVE64
554+
ALDDQU
554555
ALDMXCSR
555556
AMASKMOVOU
556557
AMASKMOVQ
@@ -751,9 +752,9 @@ const (
751752
APCLMULQDQ
752753

753754
AVZEROUPPER
754-
AMOVHDU
755-
AMOVNTHD
756-
AMOVHDA
755+
AVMOVDQU
756+
AVMOVNTDQ
757+
AVMOVDQA
757758
AVPCMPEQB
758759
AVPXOR
759760
AVPMOVMSKB

src/cmd/internal/obj/x86/anames.go

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -500,6 +500,7 @@ var Anames = []string{
500500
"FXRSTOR64",
501501
"FXSAVE",
502502
"FXSAVE64",
503+
"LDDQU",
503504
"LDMXCSR",
504505
"MASKMOVOU",
505506
"MASKMOVQ",
@@ -692,9 +693,9 @@ var Anames = []string{
692693
"PSHUFD",
693694
"PCLMULQDQ",
694695
"VZEROUPPER",
695-
"MOVHDU",
696-
"MOVNTHD",
697-
"MOVHDA",
696+
"VMOVDQU",
697+
"VMOVNTDQ",
698+
"VMOVDQA",
698699
"VPCMPEQB",
699700
"VPXOR",
700701
"VPMOVMSKB",

0 commit comments

Comments
 (0)