Skip to content

Commit 8d880da

Browse files
ianlancetaylorgopherbot
authored andcommitted
cmd/cgo/internal/test: don't skip some tests on musl
They reportedly work at least as of Alpine 3.18. Fixes #39857 Change-Id: I6a249d61d33e467bf32e8c250f870fc261b90941 Reviewed-on: https://go-review.googlesource.com/c/go/+/563096 Auto-Submit: Ian Lance Taylor <[email protected]> Commit-Queue: Ian Lance Taylor <[email protected]> LUCI-TryBot-Result: Go LUCI <[email protected]> Reviewed-by: Ian Lance Taylor <[email protected]> Reviewed-by: Austin Clements <[email protected]>
1 parent 8361329 commit 8d880da

File tree

1 file changed

+1
-14
lines changed

1 file changed

+1
-14
lines changed

src/cmd/cgo/internal/test/cgo_linux_test.go

Lines changed: 1 addition & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@
77
package cgotest
88

99
import (
10-
"os"
1110
"runtime"
1211
"testing"
1312
)
@@ -16,30 +15,18 @@ func TestSetgid(t *testing.T) {
1615
if runtime.GOOS == "android" {
1716
t.Skip("unsupported on Android")
1817
}
19-
if _, err := os.Stat("/etc/alpine-release"); err == nil {
20-
t.Skip("setgid is broken with musl libc - go.dev/issue/39857")
21-
}
2218
testSetgid(t)
2319
}
2420

2521
func TestSetgidStress(t *testing.T) {
2622
if runtime.GOOS == "android" {
2723
t.Skip("unsupported on Android")
2824
}
29-
if _, err := os.Stat("/etc/alpine-release"); err == nil {
30-
t.Skip("setgid is broken with musl libc - go.dev/issue/39857")
31-
}
3225
testSetgidStress(t)
3326
}
3427

3528
func Test1435(t *testing.T) { test1435(t) }
3629
func Test6997(t *testing.T) { test6997(t) }
37-
38-
func Test9400(t *testing.T) {
39-
if _, err := os.Stat("/etc/alpine-release"); err == nil {
40-
t.Skip("setgid is broken with musl libc - go.dev/issue/39857")
41-
}
42-
test9400(t)
43-
}
30+
func Test9400(t *testing.T) { test9400(t) }
4431

4532
func TestBuildID(t *testing.T) { testBuildID(t) }

0 commit comments

Comments
 (0)