cmd/go: don't generate DWARF in the compiler if the linker will discard it

josharian · josharian · commit 87065a3c13f3 · 2017-04-17T03:16:36.000Z
Change-Id: I7610f968f5c22b51a6a8813d6f31ccb772a12ba9 Reviewed-on: https://go-review.googlesource.com/40858 Run-TryBot: Josh Bleecher Snyder <josharian@gmail.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
diff --git a/src/cmd/go/internal/work/build.go b/src/cmd/go/internal/work/build.go
@@ -2203,6 +2203,9 @@ func (gcToolchain) gc(b *Builder, p *load.Package, archive, obj string, asmhdr b
 	if p.Internal.BuildID != "" {
 		gcargs = append(gcargs, "-buildid", p.Internal.BuildID)
 	}
+	if p.Internal.OmitDebug {
+		gcargs = append(gcargs, "-dwarf=false")
+	}
 
 	for _, path := range p.Imports {
 		if i := strings.LastIndex(path, "/vendor/"); i >= 0 {

Original file line number	Diff line number	Diff line change
`@@ -2203,6 +2203,9 @@ func (gcToolchain) gc(b Builder, p load.Package, archive, obj string, asmhdr b`
`2203`	`2203`	`if p.Internal.BuildID != "" {`
`2204`	`2204`	`gcargs = append(gcargs, "-buildid", p.Internal.BuildID)`
`2205`	`2205`	`}`
	`2206`	`+ if p.Internal.OmitDebug {`
	`2207`	`+ gcargs = append(gcargs, "-dwarf=false")`
	`2208`	`+ }`
`2206`	`2209`
`2207`	`2210`	`for _, path := range p.Imports {`
`2208`	`2211`	`if i := strings.LastIndex(path, "/vendor/"); i >= 0 {`