Skip to content

Commit 81d424e

Browse files
mknyszekgopherbot
authored andcommitted
internal/trace: fix off-by-one error in arguments for exp events
There's an off-by-one error in computing the Args field for experimental events, resulting in confusing output. This wasn't caught because no test actually checks to make sure the experimental arguments make sense yet. Change-Id: I339677a80bee6319407fced20d5e0f9c2fd235b3 Reviewed-on: https://go-review.googlesource.com/c/go/+/589055 LUCI-TryBot-Result: Go LUCI <[email protected]> Reviewed-by: Carlos Amedee <[email protected]> Auto-Submit: Michael Knyszek <[email protected]> Reviewed-by: Michael Pratt <[email protected]>
1 parent 787414c commit 81d424e

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

src/internal/trace/event.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -663,11 +663,11 @@ func (e Event) Experimental() ExperimentalEvent {
663663
panic("Experimental called on non-Experimental event")
664664
}
665665
spec := go122.Specs()[e.base.typ]
666-
argNames := spec.Args[1:]
666+
argNames := spec.Args[1:] // Skip timestamp; already handled.
667667
return ExperimentalEvent{
668668
Name: spec.Name,
669-
ArgNames: argNames, // Skip timestamp; already handled.
670-
Args: e.base.args[1 : 1+len(argNames)],
669+
ArgNames: argNames,
670+
Args: e.base.args[:len(argNames)],
671671
Data: e.table.expData[spec.Experiment],
672672
}
673673
}

0 commit comments

Comments
 (0)