Skip to content

Commit 8103130

Browse files
misc/cgo/testcshared: skip TestGo2C2Go on Windows
For #27019 Fixes #49457 Change-Id: I398abb7b555196ced34a6dd04b68195bf8bbdd38 Reviewed-on: https://go-review.googlesource.com/c/go/+/365994 Trust: Ian Lance Taylor <[email protected]> Run-TryBot: Ian Lance Taylor <[email protected]> TryBot-Result: Go Bot <[email protected]> Reviewed-by: Emmanuel Odeke <[email protected]> Reviewed-by: Cherry Mui <[email protected]> Reviewed-by: Patrik Nyblom <[email protected]>
1 parent 5a3d871 commit 8103130

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

misc/cgo/testcshared/cshared_test.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -781,10 +781,10 @@ func copyFile(t *testing.T, dst, src string) {
781781

782782
func TestGo2C2Go(t *testing.T) {
783783
switch GOOS {
784-
case "darwin", "ios":
785-
// Darwin shared libraries don't support the multiple
784+
case "darwin", "ios", "windows":
785+
// Non-ELF shared libraries don't support the multiple
786786
// copies of the runtime package implied by this test.
787-
t.Skip("linking c-shared into Go programs not supported on Darwin; issue 29061")
787+
t.Skipf("linking c-shared into Go programs not supported on %s; issue 29061, 49457", GOOS)
788788
case "android":
789789
t.Skip("test fails on android; issue 29087")
790790
}

0 commit comments

Comments
 (0)