Skip to content

Commit 7f3eb61

Browse files
committed
runtime: skip TestSegv traceback check on 386
The VDSO (__kernel_vsyscall) is reachable via asmcgocall(cgo_start_thread) on linux-386, which causes traceback to throw. Fixes #49182. For #50504. Change-Id: Idb78cb8de752203ce0ed63c2dbd2d12847338688 Reviewed-on: https://go-review.googlesource.com/c/go/+/376656 Reviewed-by: Cherry Mui <[email protected]> Trust: Michael Pratt <[email protected]> Run-TryBot: Michael Pratt <[email protected]>
1 parent c74be77 commit 7f3eb61

File tree

1 file changed

+12
-4
lines changed

1 file changed

+12
-4
lines changed

src/runtime/crash_cgo_test.go

Lines changed: 12 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -625,12 +625,20 @@ func TestSegv(t *testing.T) {
625625
// TODO(golang.org/issue/49182): Skip, runtime
626626
// throws while attempting to generate
627627
// traceback.
628-
default:
629-
nowant := "runtime: "
630-
if strings.Contains(got, nowant) {
631-
t.Errorf("unexpectedly saw %q in output", nowant)
628+
return
629+
case "linux":
630+
if runtime.GOARCH == "386" {
631+
// TODO(golang.org/issue/50504): Skip,
632+
// runtime throws while attempting to
633+
// generate traceback from VDSO call
634+
// via asmcgocall.
635+
return
632636
}
633637
}
638+
nowant := "runtime: "
639+
if strings.Contains(got, nowant) {
640+
t.Errorf("unexpectedly saw %q in output", nowant)
641+
}
634642
})
635643
}
636644
}

0 commit comments

Comments
 (0)