Skip to content

Commit 7ebe350

Browse files
cmd/compile: correct check for valid -lang version
Change-Id: Iad10d0a2dbc8e12e9f776c6cfb34070f584fd439 Reviewed-on: https://go-review.googlesource.com/c/149057 Run-TryBot: Ian Lance Taylor <[email protected]> TryBot-Result: Gobot Gobot <[email protected]> Reviewed-by: Emmanuel Odeke <[email protected]>
1 parent 5d39260 commit 7ebe350

File tree

2 files changed

+6
-1
lines changed

2 files changed

+6
-1
lines changed

src/cmd/compile/internal/gc/lang_test.go

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -41,6 +41,11 @@ func TestInvalidLang(t *testing.T) {
4141
t.Error("compilation with -lang=go9.99 succeeded unexpectedly")
4242
}
4343

44+
// This test will have to be adjusted if we ever reach 1.99 or 2.0.
45+
if testLang(t, "go1.99", src, outfile) == nil {
46+
t.Error("compilation with -lang=go1.99 succeeded unexpectedly")
47+
}
48+
4449
if testLang(t, "go1.8", src, outfile) == nil {
4550
t.Error("compilation with -lang=go1.8 succeeded unexpectedly")
4651
}

src/cmd/compile/internal/gc/main.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1444,7 +1444,7 @@ func checkLang() {
14441444
if err != nil {
14451445
log.Fatalf("internal error parsing default lang %q: %v", def, err)
14461446
}
1447-
if langWant.major > defVers.major || (langWant.major == defVers.major && langWant.major > defVers.minor) {
1447+
if langWant.major > defVers.major || (langWant.major == defVers.major && langWant.minor > defVers.minor) {
14481448
log.Fatalf("invalid value %q for -lang: max known version is %q", flag_lang, def)
14491449
}
14501450
}

0 commit comments

Comments
 (0)