Skip to content

Commit 7e5906a

Browse files
committed
net/http: remove five second timeout from TestTransportClosesBodyOnError
Wait forever and let the test time out with a stack trace if the expected response doesn't happen. Fixes #57990 Change-Id: I835def63db113752cdd06e03e258cb10d63a6a25 Reviewed-on: https://go-review.googlesource.com/c/go/+/463222 TryBot-Result: Gopher Robot <[email protected]> Run-TryBot: Damien Neil <[email protected]> Reviewed-by: Bryan Mills <[email protected]>
1 parent d49719b commit 7e5906a

File tree

1 file changed

+2
-7
lines changed

1 file changed

+2
-7
lines changed

src/net/http/transport_test.go

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -3700,13 +3700,8 @@ func testTransportClosesBodyOnError(t *testing.T, mode testMode) {
37003700
if err == nil || !strings.Contains(err.Error(), fakeErr.Error()) {
37013701
t.Fatalf("Do error = %v; want something containing %q", err, fakeErr.Error())
37023702
}
3703-
select {
3704-
case err := <-readBody:
3705-
if err == nil {
3706-
t.Errorf("Unexpected success reading request body from handler; want 'unexpected EOF reading trailer'")
3707-
}
3708-
case <-time.After(5 * time.Second):
3709-
t.Error("timeout waiting for server handler to complete")
3703+
if err := <-readBody; err == nil {
3704+
t.Errorf("Unexpected success reading request body from handler; want 'unexpected EOF reading trailer'")
37103705
}
37113706
select {
37123707
case <-didClose:

0 commit comments

Comments
 (0)