cmd/link: close cpu profile

testwill · gopherbot · commit 7b3c38045b4c · 2024-04-10T22:22:21.000Z
Change-Id: Ieaf1c165307a98d58c40d4d970eecfd6d74b2411 GitHub-Last-Rev: bd72710 GitHub-Pull-Request: #66736 Reviewed-on: https://go-review.googlesource.com/c/go/+/577416 Auto-Submit: Than McIntosh <thanm@google.com> Reviewed-by: Than McIntosh <thanm@google.com> Reviewed-by: Dmitri Shuralyov <dmitshur@google.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
diff --git a/src/cmd/link/internal/ld/main.go b/src/cmd/link/internal/ld/main.go
@@ -499,7 +499,12 @@ func startProfile() {
 		if err := pprof.StartCPUProfile(f); err != nil {
 			log.Fatalf("%v", err)
 		}
-		AtExit(pprof.StopCPUProfile)
+		AtExit(func() {
+			pprof.StopCPUProfile()
+			if err = f.Close(); err != nil {
+				log.Fatalf("error closing cpu profile: %v", err)
+			}
+		})
 	}
 	if *memprofile != "" {
 		if *memprofilerate != 0 {

Original file line number	Diff line number	Diff line change
`@@ -499,7 +499,12 @@ func startProfile() {`
`499`	`499`	`if err := pprof.StartCPUProfile(f); err != nil {`
`500`	`500`	`log.Fatalf("%v", err)`
`501`	`501`	`}`
`502`		`- AtExit(pprof.StopCPUProfile)`
	`502`	`+ AtExit(func() {`
	`503`	`+ pprof.StopCPUProfile()`
	`504`	`+ if err = f.Close(); err != nil {`
	`505`	`+ log.Fatalf("error closing cpu profile: %v", err)`
	`506`	`+ }`
	`507`	`+ })`
`503`	`508`	`}`
`504`	`509`	`if *memprofile != "" {`
`505`	`510`	`if *memprofilerate != 0 {`