Skip to content

Commit 79b425e

Browse files
committed
misc/cgo/testplugin: remove skip in TestIssue25756pie
Though this was a problem for Go 1.17, it appears not to be a problem on tip. This reverts change made in CL 321349. For #46239. Change-Id: Ie4d6649fbabce3bb2c1cf04d97760ba6ceadaca5 Reviewed-on: https://go-review.googlesource.com/c/go/+/369752 Run-TryBot: Dmitri Shuralyov <[email protected]> Reviewed-by: Cherry Mui <[email protected]> TryBot-Result: Gopher Robot <[email protected]> Trust: Dmitri Shuralyov <[email protected]>
1 parent 871d63f commit 79b425e

File tree

1 file changed

+0
-4
lines changed

1 file changed

+0
-4
lines changed

misc/cgo/testplugin/plugin_test.go

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -265,10 +265,6 @@ func TestIssue25756(t *testing.T) {
265265

266266
// Test with main using -buildmode=pie with plugin for issue #43228
267267
func TestIssue25756pie(t *testing.T) {
268-
if os.Getenv("GO_BUILDER_NAME") == "darwin-arm64-11_0-toothrot" {
269-
t.Skip("broken on darwin/arm64 builder in sharded mode; see issue 46239")
270-
}
271-
272268
goCmd(t, "build", "-buildmode=plugin", "-o", "life.so", "./issue25756/plugin")
273269
goCmd(t, "build", "-buildmode=pie", "-o", "issue25756pie.exe", "./issue25756/main.go")
274270
run(t, "./issue25756pie.exe")

0 commit comments

Comments
 (0)