Skip to content

Commit 76bb0ca

Browse files
aclementsgopherbot
authored andcommitted
runtime: delete a very stale comment
This comment claims mark termination re-scans stacks and uses the write barrier to determine how much of the stack needs to be rescanned. This hasn't been true since we introduced the hybrid write barrier and deleted stack rescanning with CL 31766 in Go 1.8. Updates #17503 I suppose. Change-Id: I5e90f25020c9fa6f146ec6ed0642ba2b4884c2a8 Reviewed-on: https://go-review.googlesource.com/c/go/+/498435 Reviewed-by: Michael Knyszek <[email protected]> Auto-Submit: Michael Knyszek <[email protected]> TryBot-Result: Gopher Robot <[email protected]> Run-TryBot: Michael Knyszek <[email protected]>
1 parent 4c1d8bf commit 76bb0ca

File tree

1 file changed

+0
-6
lines changed

1 file changed

+0
-6
lines changed

src/runtime/mbarrier.go

-6
Original file line numberDiff line numberDiff line change
@@ -112,12 +112,6 @@ import (
112112
// compiler will generate a write barrier for writes through that
113113
// pointer (because it doesn't know it's not a heap pointer).
114114
//
115-
// One might be tempted to ignore the write barrier if slot points
116-
// into to the stack. Don't do it! Mark termination only re-scans
117-
// frames that have potentially been active since the concurrent scan,
118-
// so it depends on write barriers to track changes to pointers in
119-
// stack frames that have not been active.
120-
//
121115
//
122116
// Global writes:
123117
//

0 commit comments

Comments
 (0)