Skip to content

Commit 70ee9b4

Browse files
committed
runtime: fix sysctl calling convention on netbsd/386
Thanks to coypoop for noticing at: #22914 (comment) FreeBSD/386 and NetBSD/386 diverged between Go 1.4 and Go 1.5 when Russ sent https://golang.org/cl/135830043 (git rev 25f6b02) to change the calling convention of the C compilers to match Go. But netbsd wasn't updated. Tested on a NetBSD/386 VM, since the builders aren't back up yet (due to this bug) Fixes #22914 Updates #19339 Updates #20852 Updates #16511 Change-Id: Id76ebe8f29bcc85e39b1c11090639d906cd6cf04 Reviewed-on: https://go-review.googlesource.com/80515 Run-TryBot: Brad Fitzpatrick <[email protected]> TryBot-Result: Gobot Gobot <[email protected]> Reviewed-by: Benny Siegert <[email protected]> Reviewed-by: Ian Lance Taylor <[email protected]>
1 parent 153e409 commit 70ee9b4

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

src/runtime/sys_netbsd_386.s

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -375,10 +375,12 @@ TEXT runtime·sysctl(SB),NOSPLIT,$28
375375
MOVSL // arg 6 - newlen
376376
MOVL $202, AX // sys___sysctl
377377
INT $0x80
378-
JCC 3(PC)
378+
JAE 4(PC)
379379
NEGL AX
380+
MOVL AX, ret+24(FP)
380381
RET
381382
MOVL $0, AX
383+
MOVL AX, ret+24(FP)
382384
RET
383385

384386
GLOBL runtime·tlsoffset(SB),NOPTR,$4

0 commit comments

Comments
 (0)