Skip to content

Commit 6afdf01

Browse files
author
Bryan C. Mills
committed
cmd/go: make assertions more precise in TestScript/gcflags_patterns
This fixes a rare test flake observed in https://build.golang.org/log/18e531785e7f8b3e6a6d5231787a9d8bdd4a60ea. Change-Id: I0986752f5c1abc626070b9f8ecf34c629a15cd2a Reviewed-on: https://go-review.googlesource.com/c/go/+/359735 Trust: Bryan C. Mills <[email protected]> Run-TryBot: Bryan C. Mills <[email protected]> TryBot-Result: Go Bot <[email protected]> Reviewed-by: Ian Lance Taylor <[email protected]>
1 parent 5ec2427 commit 6afdf01

File tree

1 file changed

+10
-10
lines changed

1 file changed

+10
-10
lines changed

src/cmd/go/testdata/script/gcflags_patterns.txt

+10-10
Original file line numberDiff line numberDiff line change
@@ -7,24 +7,24 @@ env GOCACHE=$WORK/gocache # Looking for compile commands, so need a clean cache
77

88
# -gcflags=-e applies to named packages, not dependencies
99
go build -n -v -gcflags=-e z1 z2
10-
stderr 'compile.* -p z1.* -e'
11-
stderr 'compile.* -p z2.* -e'
10+
stderr 'compile.* -p z1.* -e '
11+
stderr 'compile.* -p z2.* -e '
1212
stderr 'compile.* -p y'
13-
! stderr 'compile.* -p [^z].* -e'
13+
! stderr 'compile.* -p [^z].* -e '
1414

1515
# -gcflags can specify package=flags, and can be repeated; last match wins
1616
go build -n -v -gcflags=-e -gcflags=z1=-N z1 z2
17-
stderr 'compile.* -p z1.* -N'
18-
! stderr 'compile.* -p z1.* -e'
19-
! stderr 'compile.* -p z2.* -N'
20-
stderr 'compile.* -p z2.* -e'
17+
stderr 'compile.* -p z1.* -N '
18+
! stderr 'compile.* -p z1.* -e '
19+
! stderr 'compile.* -p z2.* -N '
20+
stderr 'compile.* -p z2.* -e '
2121
stderr 'compile.* -p y'
22-
! stderr 'compile.* -p [^z].* -e'
23-
! stderr 'compile.* -p [^z].* -N'
22+
! stderr 'compile.* -p [^z].* -e '
23+
! stderr 'compile.* -p [^z].* -N '
2424

2525
# -gcflags can have arbitrary spaces around the flags
2626
go build -n -v -gcflags=' z1 = -e ' z1
27-
stderr 'compile.* -p z1.* -e'
27+
stderr 'compile.* -p z1.* -e '
2828

2929
# -gcflags='all=-e' should apply to all packages, even with go test
3030
go test -c -n -gcflags='all=-e' z1

0 commit comments

Comments
 (0)