Skip to content

Commit 669d87a

Browse files
cosnicolaougopherbot
authored andcommitted
runtime/pprof: continued attempt to deflake the VMInfo test.
This change catches an additional error message to trigger skipping the test when the underlying system is failing. Fixes #62352 Change-Id: I5c12b20f3e9023597ff89fc905c0646a80ec4811 Reviewed-on: https://go-review.googlesource.com/c/go/+/637995 Reviewed-by: Cherry Mui <[email protected]> Auto-Submit: Michael Pratt <[email protected]> Reviewed-by: Michael Pratt <[email protected]> LUCI-TryBot-Result: Go LUCI <[email protected]>
1 parent 45f4913 commit 669d87a

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

src/runtime/pprof/vminfo_darwin_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -97,7 +97,7 @@ func useVMMap(t *testing.T) (hi, lo uint64, retryable bool, err error) {
9797
t.Logf("vmmap output: %s", out)
9898
if ee, ok := cmdErr.(*exec.ExitError); ok && len(ee.Stderr) > 0 {
9999
t.Logf("%v: %v\n%s", cmd, cmdErr, ee.Stderr)
100-
if testing.Short() && strings.Contains(string(ee.Stderr), "No process corpse slots currently available, waiting to get one") {
100+
if testing.Short() && (strings.Contains(string(ee.Stderr), "No process corpse slots currently available, waiting to get one") || strings.Contains(string(ee.Stderr), "Failed to generate corpse from the process")) {
101101
t.Skipf("Skipping knwn flake in short test mode")
102102
}
103103
retryable = bytes.Contains(ee.Stderr, []byte("resource shortage"))

0 commit comments

Comments
 (0)