Skip to content

Commit 656f27e

Browse files
committed
cmd/compile: enable -d=checkptr even on windows
CL 201783 enable -d=checkptr when -race or -msan is specified everywhere but windows. But, now that all unsafe pointer conversions in the standard library are fixed, enable -d=checkptr even on windows. Updates #34964 Updates #34972 Change-Id: Id912fa83b0d5b46c6f1c134c742fd94d2d185835 Reviewed-on: https://go-review.googlesource.com/c/go/+/227003 Run-TryBot: Alex Brainman <[email protected]> Reviewed-by: Brad Fitzpatrick <[email protected]>
1 parent 9f40f9f commit 656f27e

File tree

1 file changed

+2
-3
lines changed

1 file changed

+2
-3
lines changed

src/cmd/compile/internal/gc/main.go

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -379,9 +379,8 @@ func Main(archInit func(*Arch)) {
379379
if flag_race && flag_msan {
380380
log.Fatal("cannot use both -race and -msan")
381381
}
382-
if (flag_race || flag_msan) && objabi.GOOS != "windows" {
383-
// -race and -msan imply -d=checkptr for now (except on windows).
384-
// TODO(mdempsky): Re-evaluate before Go 1.14. See #34964.
382+
if flag_race || flag_msan {
383+
// -race and -msan imply -d=checkptr for now.
385384
Debug_checkptr = 1
386385
}
387386
if ispkgin(omit_pkgs) {

0 commit comments

Comments
 (0)