Skip to content

Commit 63e29ad

Browse files
cmd/go: don't pass -test.testlogfile on NaCl
It causes every test to fail as the log file is on the local file system, not the NaCl file system. Updates #22593 Change-Id: Iee3d8307317bd792c9c701baa962ebbbfa34c147 Reviewed-on: https://go-review.googlesource.com/83256 Run-TryBot: Ian Lance Taylor <[email protected]> Reviewed-by: Brad Fitzpatrick <[email protected]>
1 parent 4312390 commit 63e29ad

File tree

2 files changed

+3
-1
lines changed

2 files changed

+3
-1
lines changed

src/cmd/go/internal/test/test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1266,7 +1266,7 @@ func (c *runCache) builderRunTest(b *work.Builder, a *work.Action) error {
12661266
}
12671267

12681268
testlogArg := []string{}
1269-
if !c.disableCache {
1269+
if !c.disableCache && cfg.Goos != "nacl" {
12701270
testlogArg = []string{"-test.testlogfile=" + a.Objdir + "testlog.txt"}
12711271
}
12721272
args := str.StringList(work.FindExecCmd(), a.Deps[0].Target, testlogArg, testArgs)
Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
1+
#!/bin/sh
2+
exit 0

0 commit comments

Comments
 (0)