misc: ensure that test overlay directories are writable

Otherwise, the test cannot create new files in the directory.

Updates #32407
Updates #30316

Change-Id: Ief0df94a202be92f57d458d4ab4e4daa9ec189b1
Reviewed-on: https://go-review.googlesource.com/c/go/+/206458
Run-TryBot: Bryan C. Mills <[email protected]>
TryBot-Result: Gobot Gobot <[email protected]>
Reviewed-by: Brad Fitzpatrick <[email protected]>

Author: Bryan C. Mills

misc/cgo/life/overlaydir_test.go

@@ -52,7 +52,7 @@ func overlayDir(dstRoot, srcRoot string) error {
 		// Always copy directories (don't symlink them).
 		// If we add a file in the overlay, we don't want to add it in the original.
 		if info.IsDir() {
-			return os.Mkdir(dstPath, perm)
+			return os.Mkdir(dstPath, perm|0200)
 		}
 
 		// If the OS supports symlinks, use them instead of copying bytes.

misc/cgo/stdio/overlaydir_test.go

@@ -52,7 +52,7 @@ func overlayDir(dstRoot, srcRoot string) error {
 		// Always copy directories (don't symlink them).
 		// If we add a file in the overlay, we don't want to add it in the original.
 		if info.IsDir() {
-			return os.Mkdir(dstPath, perm)
+			return os.Mkdir(dstPath, perm|0200)
 		}
 
 		// If the OS supports symlinks, use them instead of copying bytes.

misc/cgo/test/overlaydir_test.go

@@ -52,7 +52,7 @@ func overlayDir(dstRoot, srcRoot string) error {
 		// Always copy directories (don't symlink them).
 		// If we add a file in the overlay, we don't want to add it in the original.
 		if info.IsDir() {
-			return os.Mkdir(dstPath, perm)
+			return os.Mkdir(dstPath, perm|0200)
 		}
 
 		// If the OS supports symlinks, use them instead of copying bytes.

misc/cgo/testcarchive/overlaydir_test.go

@@ -52,7 +52,7 @@ func overlayDir(dstRoot, srcRoot string) error {
 		// Always copy directories (don't symlink them).
 		// If we add a file in the overlay, we don't want to add it in the original.
 		if info.IsDir() {
-			return os.Mkdir(dstPath, perm)
+			return os.Mkdir(dstPath, perm|0200)
 		}
 
 		// If the OS supports symlinks, use them instead of copying bytes.

misc/cgo/testcshared/overlaydir_test.go

@@ -52,7 +52,7 @@ func overlayDir(dstRoot, srcRoot string) error {
 		// Always copy directories (don't symlink them).
 		// If we add a file in the overlay, we don't want to add it in the original.
 		if info.IsDir() {
-			return os.Mkdir(dstPath, perm)
+			return os.Mkdir(dstPath, perm|0200)
 		}
 
 		// If the OS supports symlinks, use them instead of copying bytes.

misc/cgo/testplugin/overlaydir_test.go

@@ -52,7 +52,7 @@ func overlayDir(dstRoot, srcRoot string) error {
 		// Always copy directories (don't symlink them).
 		// If we add a file in the overlay, we don't want to add it in the original.
 		if info.IsDir() {
-			return os.Mkdir(dstPath, perm)
+			return os.Mkdir(dstPath, perm|0200)
 		}
 
 		// If the OS supports symlinks, use them instead of copying bytes.

misc/cgo/testshared/overlaydir_test.go

@@ -52,7 +52,7 @@ func overlayDir(dstRoot, srcRoot string) error {
 		// Always copy directories (don't symlink them).
 		// If we add a file in the overlay, we don't want to add it in the original.
 		if info.IsDir() {
-			return os.Mkdir(dstPath, perm)
+			return os.Mkdir(dstPath, perm|0200)
 		}
 
 		// If the OS supports symlinks, use them instead of copying bytes.

misc/cgo/testso/overlaydir_test.go

@@ -52,7 +52,7 @@ func overlayDir(dstRoot, srcRoot string) error {
 		// Always copy directories (don't symlink them).
 		// If we add a file in the overlay, we don't want to add it in the original.
 		if info.IsDir() {
-			return os.Mkdir(dstPath, perm)
+			return os.Mkdir(dstPath, perm|0200)
 		}
 
 		// If the OS supports symlinks, use them instead of copying bytes.

misc/cgo/testsovar/overlaydir_test.go

@@ -52,7 +52,7 @@ func overlayDir(dstRoot, srcRoot string) error {
 		// Always copy directories (don't symlink them).
 		// If we add a file in the overlay, we don't want to add it in the original.
 		if info.IsDir() {
-			return os.Mkdir(dstPath, perm)
+			return os.Mkdir(dstPath, perm|0200)
 		}
 
 		// If the OS supports symlinks, use them instead of copying bytes.

misc/reboot/overlaydir_test.go

@@ -51,7 +51,7 @@ func overlayDir(dstRoot, srcRoot string) error {
 		// Always copy directories (don't symlink them).
 		// If we add a file in the overlay, we don't want to add it in the original.
 		if info.IsDir() {
-			return os.Mkdir(dstPath, perm)
+			return os.Mkdir(dstPath, perm|0200)
 		}
 
 		// If the OS supports symlinks, use them instead of copying bytes.