runtime: if runtime is stale while testing, show StaleReason

ianlancetaylor · ianlancetaylor · commit 62237c2c8ef2 · 2017-02-13T23:46:12.000Z
Update #19062. Change-Id: I7397b573389145b56e73d2150ce0fc9aa75b3caa Reviewed-on: https://go-review.googlesource.com/36934 Run-TryBot: Ian Lance Taylor <iant@golang.org> Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>
diff --git a/src/runtime/crash_test.go b/src/runtime/crash_test.go
@@ -165,6 +165,11 @@ func checkStaleRuntime(t *testing.T) {
 		}
 		if string(out) != "false\n" {
 			t.Logf("go list -f {{.Stale}} runtime:\n%s", out)
+			out, err := testEnv(exec.Command(testenv.GoToolPath(t), "list", "-f", "{{.StaleReason}}", "runtime")).CombinedOutput()
+			if err != nil {
+				t.Logf("go list -f {{.StaleReason}} failed: %v", err)
+			}
+			t.Logf("go list -f {{.StaleReason}} runtime:\n%s", out)
 			staleRuntimeErr = fmt.Errorf("Stale runtime.a. Run 'go install runtime'.")
 		}
 	})

Original file line number	Diff line number	Diff line change
`@@ -165,6 +165,11 @@ func checkStaleRuntime(t *testing.T) {`
`165`	`165`	`}`
`166`	`166`	`if string(out) != "false\n" {`
`167`	`167`	`t.Logf("go list -f {{.Stale}} runtime:\n%s", out)`
	`168`	`+ out, err := testEnv(exec.Command(testenv.GoToolPath(t), "list", "-f", "{{.StaleReason}}", "runtime")).CombinedOutput()`
	`169`	`+ if err != nil {`
	`170`	`+ t.Logf("go list -f {{.StaleReason}} failed: %v", err)`
	`171`	`+ }`
	`172`	`+ t.Logf("go list -f {{.StaleReason}} runtime:\n%s", out)`
`168`	`173`	`staleRuntimeErr = fmt.Errorf("Stale runtime.a. Run 'go install runtime'.")`
`169`	`174`	`}`
`170`	`175`	`})`