Skip to content

Commit 5efa4da

Browse files
author
Bryan C. Mills
committed
cmd/go: skip TestScript/mod_replace_gopkgin
(Until it can be made hermetic.) The gopkg.in service has had a lot of flakiness lately. Go users in general are isolated from that flakiness by the Go module mirror (proxy.golang.org), but this test intentionally bypasses the module mirror because the mirror itself uses cmd/go to download the module. In the long term, we can redirect the gopkg.in URL to the local (in-process) vcweb server added for #27494. In the meantime, let's skip the test to reduce the impact of upstream outages. For #54503. Change-Id: Icf3de7ca416db548e53864a71776fe22b444fcea Reviewed-on: https://go-review.googlesource.com/c/go/+/454503 Run-TryBot: Bryan Mills <[email protected]> Auto-Submit: Bryan Mills <[email protected]> TryBot-Result: Gopher Robot <[email protected]> Reviewed-by: Heschi Kreinick <[email protected]>
1 parent 79559c1 commit 5efa4da

File tree

1 file changed

+3
-0
lines changed

1 file changed

+3
-0
lines changed

src/cmd/go/testdata/script/mod_replace_gopkgin.txt

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,9 @@
44
# even if there is an explicit go.mod file containing the
55
# gopkg.in path.
66

7+
skip 'skipping test that depends on an unreliable third-party server; see https://go.dev/issue/54503'
8+
# TODO(#54043): Make this test hermetic and re-enable it.
9+
710
[short] skip
811
[!net] skip
912
[!git] skip

0 commit comments

Comments
 (0)