Skip to content

Commit 5df1fe5

Browse files
committed
runtime: always rebuild in TestIntendedInlining
This is necessary when you aren't actively changing the runtime. Oops. Also, run the tests on the builders, to avoid silent failures (#17472). Change-Id: I1fc03790cdbddddb07026a772137a79919dcaac7 Reviewed-on: https://go-review.googlesource.com/58050 Run-TryBot: Josh Bleecher Snyder <[email protected]> TryBot-Result: Gobot Gobot <[email protected]> Reviewed-by: Ian Lance Taylor <[email protected]>
1 parent 9d3d370 commit 5df1fe5

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

src/runtime/runtime_test.go

+2-2
Original file line numberDiff line numberDiff line change
@@ -362,7 +362,7 @@ func TestVersion(t *testing.T) {
362362
// This allows refactoring for code clarity and re-use without fear that
363363
// changes to the compiler will cause silent performance regressions.
364364
func TestIntendedInlining(t *testing.T) {
365-
if testing.Short() {
365+
if testing.Short() && testenv.Builder() == "" {
366366
t.Skip("skipping in short mode")
367367
}
368368
testenv.MustHaveGoRun(t)
@@ -376,7 +376,7 @@ func TestIntendedInlining(t *testing.T) {
376376
m[s] = true
377377
}
378378

379-
cmd := testEnv(exec.Command(testenv.GoToolPath(t), "build", "-gcflags=-m", "runtime"))
379+
cmd := testEnv(exec.Command(testenv.GoToolPath(t), "build", "-a", "-gcflags=-m", "runtime"))
380380
out, err := cmd.CombinedOutput()
381381
if err != nil {
382382
t.Logf("%s", out)

0 commit comments

Comments
 (0)