Skip to content

Commit 5b45e19

Browse files
heschidmitshur
authored andcommitted
[release-branch.go1.17] net: skip TestDialCancel on darwin-arm64
We're turning up Macs in a network environment that clashes with this test. I don't think it's critical to get it working, so skip it. For #49149. Fixes #52705. Change-Id: I925e3ecc5356c4cefd208bdcff3d98021215d0b4 Reviewed-on: https://go-review.googlesource.com/c/go/+/402181 Reviewed-by: Alex Rakoczy <[email protected]> Run-TryBot: Heschi Kreinick <[email protected]> Auto-Submit: Heschi Kreinick <[email protected]> TryBot-Result: Gopher Robot <[email protected]> (cherry picked from commit 06b0a65) Reviewed-on: https://go-review.googlesource.com/c/go/+/405295 Run-TryBot: Dmitri Shuralyov <[email protected]> Reviewed-by: Dmitri Shuralyov <[email protected]> Reviewed-by: Heschi Kreinick <[email protected]>
1 parent feec92c commit 5b45e19

File tree

1 file changed

+6
-0
lines changed

1 file changed

+6
-0
lines changed

src/net/dial_test.go

+6
Original file line numberDiff line numberDiff line change
@@ -751,6 +751,12 @@ func TestDialerKeepAlive(t *testing.T) {
751751
func TestDialCancel(t *testing.T) {
752752
mustHaveExternalNetwork(t)
753753

754+
if strings.HasPrefix(testenv.Builder(), "darwin-arm64") {
755+
// The darwin-arm64 machines run in an environment that's not
756+
// compatible with this test.
757+
t.Skipf("builder %q gives no route to host for 198.18.0.0", testenv.Builder())
758+
}
759+
754760
blackholeIPPort := JoinHostPort(slowDst4, "1234")
755761
if !supportsIPv4() {
756762
blackholeIPPort = JoinHostPort(slowDst6, "1234")

0 commit comments

Comments
 (0)