Skip to content

Commit 56284f9

Browse files
committed
src/buildall.bash: remove mobile filter
Mobile targets are not supported by misc-compile trybots, as tracked in golang.org/issue/25963, and need to be filtered out. The buildall.bash script was created in CL 9438, back when it was a single all-compile builder, and it was easier to filter out mobile targets in the script than to come up with a pattern that matches all non-mobile targets. As of CL 254740, all mobile targets (Android and iOS) have unique GOOS values. That makes it it easy to filter them out in x/build/dashboard. This was done in CL 258057. As a result, it's now viable to simplify this script and perform all misc-compile target selection in x/build, rather than having it spread it across two places. Also, as of CL 10750, the all-compile builder has turned into multiple misc-compile builders, so update the script description accordingly. Updates #41610. Change-Id: I1e33260ac18cf0a70bb68cd8e3db5587100c7e87 Reviewed-on: https://go-review.googlesource.com/c/go/+/257962 Run-TryBot: Dmitri Shuralyov <[email protected]> TryBot-Result: Go Bot <[email protected]> Reviewed-by: Alexander Rakoczy <[email protected]> Trust: Dmitri Shuralyov <[email protected]>
1 parent a9c75ec commit 56284f9

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

src/buildall.bash

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,10 +3,10 @@
33
# Use of this source code is governed by a BSD-style
44
# license that can be found in the LICENSE file.
55

6-
# Usage: buildall.sh [-e] [pattern]
6+
# Usage: buildall.bash [-e] [pattern]
77
#
88
# buildall.bash builds the standard library for all Go-supported
9-
# architectures. It is used by the "all-compile" trybot builder,
9+
# architectures. It is used by the "misc-compile" trybot builders,
1010
# as a smoke test to quickly flag portability issues.
1111
#
1212
# Options:
@@ -42,7 +42,7 @@ gettargets() {
4242
}
4343

4444
selectedtargets() {
45-
gettargets | egrep -v 'android-arm|darwin-arm64' | egrep "$pattern"
45+
gettargets | egrep "$pattern"
4646
}
4747

4848
# put linux first in the target list to get all the architectures up front.

0 commit comments

Comments
 (0)